From 893a7190e894ec9995de0d60734c61afb04c5e72 Mon Sep 17 00:00:00 2001 From: Devdutt Shenoi Date: Sat, 30 Mar 2024 15:20:44 +0530 Subject: [PATCH 1/2] fix: need not retry HTTP status errors (#332) --- uplink/src/collector/downloader.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uplink/src/collector/downloader.rs b/uplink/src/collector/downloader.rs index abe8e53c..0d2f0ef3 100644 --- a/uplink/src/collector/downloader.rs +++ b/uplink/src/collector/downloader.rs @@ -185,7 +185,7 @@ impl FileDownloader { loop { match self.download(req, &mut download).await { Ok(_) => break, - Err(Error::Reqwest(e)) => error!("Download failed: {e}"), + Err(Error::Reqwest(e)) if !e.is_status() => error!("Download failed: {e}"), Err(e) => return Err(e), } tokio::time::sleep(Duration::from_secs(1)).await; From 88b0fba332cfda13ef17f1780e7a6ee80c4abcc1 Mon Sep 17 00:00:00 2001 From: Devdutt Shenoi Date: Mon, 1 Apr 2024 14:30:56 +0530 Subject: [PATCH 2/2] deprecate kind field in actions (#331) --- uplink/src/base/actions.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/uplink/src/base/actions.rs b/uplink/src/base/actions.rs index 047950bf..1433a1ea 100644 --- a/uplink/src/base/actions.rs +++ b/uplink/src/base/actions.rs @@ -13,8 +13,6 @@ pub struct Action { // action id #[serde(alias = "id")] pub action_id: String, - // determines if action is a process - pub kind: String, // action name pub name: String, // action payload. json. can be args/payload. depends on the invoked command