Update to [email protected] #174
Conversation
|
Incidentally, I created a patch making it easier to support multiple WASI versions just recently. I just opened #175 to land that separate from the work I did it for (which you can see here), and think it'd probably make sense to rebase this PR on top of it to reduce code duplication. Also, it'd be nice to document what changed in terms of functionality, if anything. |
|
Absolutely fine to rebase this, I just needed to get it together for the ComponentizeJS release which has been made now on this branch, but we can refactor further no problem. |
|
@tschneidereit I understand you have a better architecture in mind here, but for what it is worth I've rebased this PR to main now. |
There was a problem hiding this comment.
I think you should be able to shrink this diff substantially by not duplicating all of the host_api implementation, and most everything else except for the WIT and the generated bindings.
You can see an approach to doing this in my branch for the http-body-append (not-yet) proposal here: https://github.com/bytecodealliance/StarlingMonkey/tree/wasi-http-body-append/host-apis/wasi-0.2.x-pre
Happy to talk through all of this in case it's not clear—or also to take this on myself so we have an example in-tree.
This adds a host implementation for [email protected], and sets it to the default.
Resolves #172.