This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
silence deprecation warnings in lucet-benchmarks #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
force-pushed
the
pch/silence_bench_deprecated
branch
from
7e80746
to
716ebd4
Compare
we do not believe this vulnerablity is reachable in our project
pchickey
force-pushed
the
pch/silence_bench_deprecated
branch
from
b0e66d1
to
147b18b
Compare
jedisct1
reviewed
Oct 22, 2021
Comment on lines
+1
to
+5
| // This crate uses several Criterion APIs which are deprecated. However, the | ||
| // Lucet project is in maintence mode and we no longer really care about | ||
| // maintaining and updating these interfaces, so we will ignore these | ||
| // warnings: | ||
| #![allow(deprecated)] |
There was a problem hiding this comment.
Maybe a better fix would simply be to add the html_reports feature to the criterion dependency in cargo.toml?
|
MacOS CI should be fixed by #680 |
pchickey
force-pushed
the
pch/silence_bench_deprecated
branch
from
147b18b
to
d143f71
Compare
acfoltzer
approved these changes
Oct 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucet is in maintenance mode! But that maintence needs to be focused on things that matter.
criterioninlucet-benchmarks: we are not concerned with upgradinglucet-benchmarksto the new apis, because the project is nearing the end of its life.cargo audit