Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this library still needed? #7

Open
Qqwy opened this issue Oct 5, 2024 · 1 comment
Open

Is this library still needed? #7

Qqwy opened this issue Oct 5, 2024 · 1 comment

Comments

@Qqwy
Copy link

Qqwy commented Oct 5, 2024

The Hackage package description reads:

This package provides specializations of runST that avoid a needless data-constructor allocation for the returned value. If issue 15127 is resolved, this package will no longer be necessary.

But notably, that GHC issue has been closed a few years back, specifically by the commit https://gitlab.haskell.org/ghc/ghc/-/commit/46720997a0b1fa2971a884adf43de096ce130a7e

@andrewthad
Copy link
Member

Yes, this library is no longer needed. Generally, I’ve been a little reluctant to remove it in the places where it had already been used. What this library does cannot possibly make performance worse. From the times that I have removed this from use and before-and-after spot checked the optimized Core that GHC produces, it looks like the optimization that GHC added, does in fact work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants