Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More graceful failure during shutdown #4

Open
bzier opened this issue Mar 18, 2017 · 1 comment
Open

More graceful failure during shutdown #4

bzier opened this issue Mar 18, 2017 · 1 comment

Comments

@bzier
Copy link
Owner

bzier commented Mar 18, 2017

Shutting down the HTTP Server sometimes fails with a broken pipe. It seems like this may be because the emulator process has already stopped by the time the server tries sending the response. This situation should be handled more gracefully. Relevant code

@bzier bzier changed the title More graceful failure of shutdown More graceful failure during shutdown Mar 18, 2017
@bzier bzier added the bug label Mar 18, 2017
@bzier
Copy link
Owner Author

bzier commented May 5, 2018

This isn't exactly the same error as described above (haven't actually seen that one in a long time). However, another somewhat related issue is that if you close() the environment, and you then attempt to make() a new one in the same python process, make() fails with:

socket.error: [Errno 98] Address already in use

Found a resolution to this by adding the following line to my shutdown() method:

super(ControllerHTTPServer, self).server_close()

Noting this here to come back on another branch later. In the middle of other stuff right now.

bzier added a commit that referenced this issue May 19, 2018
@bzier bzier added this to the Milestone 1 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant