Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest gym library #41

Open
bzier opened this issue Mar 21, 2018 · 1 comment · May be fixed by #70
Open

Upgrade to latest gym library #41

bzier opened this issue Mar 21, 2018 · 1 comment · May be fixed by #70

Comments

@bzier
Copy link
Owner

bzier commented Mar 21, 2018

Problem:

There was a breaking change made to the gym library a couple months ago which is affecting the initialization of the environment. The gym library was at version 0.7.4 for a long time (almost a year) and was working fine. The latest version (0.9.6 - see here) includes the breaking change. This issue is to track updating the project to account for these breaking changes.

Changes required:

At least the following:

  • Multi-discrete action space needs to match the new format
  • The new format for the action space will likely require a shift of values (e.g. instead of [-80,80] it will be [0, 160], so need to add/subtract 80 to maintain current behavior)

Workaround:

In the meantime, to get up-and-running, just change two files in the base gym-mupen64plus directory:

Each of them should have the gym library set explicitly to use the older version (gym=0.7.4 or gym==0.7.4), which should then behave as expected. The setup process may need to be re-run after making this change.

See #40 for the resulting broken behavior with the new version of gym.

@bzier
Copy link
Owner Author

bzier commented Mar 21, 2018

Looking for response on this issue. Can likely proceed without answers, but would be best to get them prior to re-working the code here.

bzier added a commit that referenced this issue Mar 24, 2018
Since the gym platform made breaking changes in 0.9.6, this change will lock the dependency at the known working version 0.7.4. Issue #41 is open to track the upgrade to the latest version.
bzier added a commit that referenced this issue May 4, 2019
Mostly upgrading to get rid of the Github warning for PyYAML (CVE-2017-18342), but figured I might as well upgrade a few others as well... Gym still needs to be upgraded (see #41).
I did some really basic testing to ensure stuff still runs. No guarantees that I didn't break something subtle though...
@roclark roclark linked a pull request Sep 18, 2019 that will close this issue
@bzier bzier added this to the Milestone 2 - Upgrades milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant