Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate step action #66

Open
bzier opened this issue May 27, 2018 · 0 comments
Open

Validate step action #66

bzier opened this issue May 27, 2018 · 0 comments

Comments

@bzier
Copy link
Owner

bzier commented May 27, 2018

Currently the environment (including both game envs) does not validate the action value that is passed to the _step(action) call. It turns out that in certain circumstances, this could allow an agent to incorrectly 'escape' from the confines of the game, navigate menus, etc, which it shouldn't be able to do. See here for an example.

This should be added at the top of each overload of _step(action):

assert self.action_space.contains(action)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant