From 988e87b47290be771f770a7e6bb6f39b9c0f446b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20M=C3=BCnch?= Date: Sun, 11 Feb 2024 19:39:57 +0100 Subject: [PATCH 1/2] Quotes all arguments used by MagentoCoreProxyCommand (#1406) The PHP binary path can contain spaces which cause issues. --- src/N98/Magento/Command/MagentoCoreProxyCommand.php | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/N98/Magento/Command/MagentoCoreProxyCommand.php b/src/N98/Magento/Command/MagentoCoreProxyCommand.php index 313169d1..73a606df 100644 --- a/src/N98/Magento/Command/MagentoCoreProxyCommand.php +++ b/src/N98/Magento/Command/MagentoCoreProxyCommand.php @@ -72,8 +72,13 @@ protected function execute(InputInterface $input, OutputInterface $output) ); } + $shellCommand = escapeshellarg(OperatingSystem::getPhpBinary()) + . ' ' + . escapeshellarg($this->magentoRootDir . '/bin/magento') + . ' ' + . $magentoCoreCommandInput->__toString(); $process = Process::fromShellCommandline( - OperatingSystem::getPhpBinary() . ' ' . $this->magentoRootDir . '/bin/magento ' . $magentoCoreCommandInput->__toString(), + $shellCommand, $this->magentoRootDir, $envVariablesForBinMagento ); From 03bd3ac7f2e13111e1f8ff6dbd25592e56c47f5d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 6 Feb 2024 21:50:05 +0000 Subject: [PATCH 2/2] Bump webfactory/ssh-agent from 0.8.0 to 0.9.0 Bumps [webfactory/ssh-agent](https://github.com/webfactory/ssh-agent) from 0.8.0 to 0.9.0. - [Release notes](https://github.com/webfactory/ssh-agent/releases) - [Changelog](https://github.com/webfactory/ssh-agent/blob/master/CHANGELOG.md) - [Commits](https://github.com/webfactory/ssh-agent/compare/v0.8.0...v0.9.0) --- updated-dependencies: - dependency-name: webfactory/ssh-agent dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .github/workflows/deploy.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 73075f05..97bfdfb6 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -144,7 +144,7 @@ jobs: steps: - name: Checkout HEAD uses: actions/checkout@v4.1.1 - - uses: webfactory/ssh-agent@v0.8.0 + - uses: webfactory/ssh-agent@v0.9.0 with: ssh-private-key: ${{ secrets.DIST_REPO_DEPLOY_KEY }} - name: Download artifacts