Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admission Controller Support #32

Open
jonathan-mayer opened this issue Sep 3, 2024 · 3 comments
Open

Add Admission Controller Support #32

jonathan-mayer opened this issue Sep 3, 2024 · 3 comments
Assignees
Labels
missing feature A feature still missing from the GoKubeDownscaler, compared to the py-kube-downscaler

Comments

@jonathan-mayer
Copy link
Member

Issue

Currently there is no admission controller support.

Problem to solve

We need to implement a way to use an admission controller

Further details

Proposal

Find out what the admission controller does in the py-kube-downscaler and implement it in the GoKubeDownscaler.

Who can address the issue

Go Dev, preferably one who knows how admission controllers work and what it does in py-kube-downscaler

Other links/references

@jonathan-mayer jonathan-mayer added the missing feature A feature still missing from the GoKubeDownscaler, compared to the py-kube-downscaler label Sep 3, 2024
@samuel-esp
Copy link
Contributor

Assign it to me, I'll try to work on it after label matching with regex

@jonathan-mayer
Copy link
Member Author

Perfect, but label matching with regex is actually done already.

@samuel-esp
Copy link
Contributor

Perfect Jonathan! Didn't know that, even better then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing feature A feature still missing from the GoKubeDownscaler, compared to the py-kube-downscaler
Projects
None yet
Development

No branches or pull requests

2 participants