Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug M dictionairy unpacking in utils. #343

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Debug M dictionairy unpacking in utils. #343

merged 2 commits into from
Mar 14, 2024

Conversation

LinuxIsCool
Copy link
Contributor

  1. Add support for the case where all system params have same length that is not 1. For example:
    params = {
        'c':[1, 2],
        'd':[1, 2],
    }
  1. Add test for easy_run

@danlessa
Copy link
Member

danlessa commented Jan 5, 2024 •
edited
Loading

@LinuxIsCool would you mind adding a new test that reproduces the bug that this PR intends to fix?

Eg. test_sweep_params_equal_length

It would be even cooler if the count of parameters / length of the param list is parametrized

@LinuxIsCool
Copy link
Contributor Author

@danlessa It's here: https://github.com/longtailfinancial/cadCAD/blob/16703b306f04f0c54f7ae72d6ff0754b2053ba3f/testing/tools/test_tools.py#L32

@danlessa danlessa mentioned this pull request Jan 19, 2024
Merged
@danlessa
Copy link
Member

danlessa commented Mar 11, 2024 •
edited
Loading

LGTM

@emanuellima1 emanuellima1 merged commit 3317b82 into cadCAD-org:master Mar 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanuellima1 emanuellima1 emanuellima1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LinuxIsCool @danlessa @emanuellima1