Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headers aren't passed to cloudfront #7

Open
VivienGiraud opened this issue Aug 8, 2019 · 4 comments
Open

Headers aren't passed to cloudfront #7

VivienGiraud opened this issue Aug 8, 2019 · 4 comments

Comments

@VivienGiraud
Copy link

Hello,
I installed your app using serverless repo on AWS, it works lovely thanks for it!
I would like to use cloudfront cache capability but unfortunately it seems that your app does not forward headers.
As you can see on these examples :
Cache-Control is passed : https://tridea-cdn.s3.eu-west-3.amazonaws.com/favicon.ico
Cache-Control isn't passed : https://5xh7ydv0n6.execute-api.eu-west-3.amazonaws.com/production/favicon.ico

Could you please update your code to handle it?
Or if the error comes from my side could you help please :)

@VivienGiraud
Copy link
Author

@cagataygurturk Any plane to do it?

@modgahead
Copy link

@VivienGiraud Hello. I have the same problem. Could you please tell me - how you resolved this?

@VivienGiraud
Copy link
Author

@modgahead We just throw it, manually resize to every size required and put it to our CDN...

@mathew-adams
Copy link

Hi also looking for this feature. Cache-control would be a welcomed feature to help combat the round-trips to the function if this could be cached completely on the client side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants