Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYSTEM_ALERT_WINDOW permission #122

Open
IzzySoft opened this issue Dec 30, 2024 · 20 comments
Open

SYSTEM_ALERT_WINDOW permission #122

IzzySoft opened this issue Dec 30, 2024 · 20 comments

Comments

@IzzySoft
Copy link
Contributor

on the last update at 2024-12-27, the scanner here yielded a new permission was added: android.permission.SYSTEM_ALERT_WINDOW. Could you please clarify what this is needed/used for, so we can add it to the "green list" of your app? Thanks in advance!
@IzzySoft
Copy link
Contributor Author

PS, another alert:

! org.cagnulein.qzcompanionnordictracktreadmill: needs NonFreeComp, needs NonFreeNet, needs Tracking

Looks like you added some proprietary/non-free dependencies – oh gosh, please say that was an accident: MLKit, Firebase, GMS… The first one is the main culprit, having the other ones dragged in. Is that really needed? For now I had to add a block of anti-features 😢 And it brought the app to the dark gray area of our inclusion policy.

@cagnulein
Copy link
Owner

cagnulein commented Dec 30, 2024 via email

@IzzySoft
Copy link
Contributor Author

Thanks @cagnulein – and yes, switching to a libre replacement would be much appreciated 😉

@cagnulein
Copy link
Owner

it could take some time, i will let you know, for now mask it unfortunately :(

@IzzySoft
Copy link
Contributor Author

For now the anti-features are in place. Knowing you'll eventually work on it, I guess we can live with that for a while. It will just be temporary. So first, happy new year!

@stale Stale
Copy link

stale bot commented Jan 15, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 15, 2025
@IzzySoft
Copy link
Contributor Author

chuckle your bot is too fast again I guess 🙈

@stale stale bot removed the wontfix This will not be worked on label Jan 15, 2025
@IzzySoft
Copy link
Contributor Author

Btw, as APK size also has jumped from ~4 MB to ~20 MB, I've had to reduce the number of versions we can keep to 2 (still beyond the per-app size limit, but I hope your replacements will get it down a bit again).

@cagnulein
Copy link
Owner

cagnulein commented Jan 16, 2025 via email

@IzzySoft
Copy link
Contributor Author

And OCR is needed "at the core" – or could be "outsourced" to an addon? I mean, it's a jump by almost factor 10 then in size if it gets "even larger" (it was less than 4 MB before, and is more than 20 MB already now). Just wondering. We might have to go with a single version only at IoD then.

@cagnulein
Copy link
Owner

cagnulein commented Jan 16, 2025 via email

@IzzySoft
Copy link
Contributor Author

is the app download regularly from there?

Our updater downloads it from here, scans it, applies several security checks – and when it passes them, places it into our repo. Clients then will provide it from our repo, i.e. the "verified APK" – all else would mean potential causes of error (believe it or not, but devs delete releases, replace APKs, etc).

So our repo stores up to 3 versions (to provide some overlap for index updates: if e.g. your client updates the index now, then we push an update an hour, and again an hour later you want to install something your index thinks is there but was just updated, we still have the copy you were looking at). "up to" means "3 versions or per-app-size-limit, whatever is reached first". We're currently allowing for 2 versions of Treadmill, despite that exceeding the max-size by 1/3.

@cagnulein
Copy link
Owner

cagnulein commented Jan 16, 2025 via email

@IzzySoft
Copy link
Contributor Author

Checking the stats from last week:

  • 2025-01-07 3 downloads
  • 2025-01-08 3 downloads
  • 2025-01-10 1 download

So not the high numbers of other apps:

Image

But then, we didn't expect such numbers. But downloads, still, yes.

@cagnulein
Copy link
Owner

cagnulein commented Jan 17, 2025 via email

@IzzySoft
Copy link
Contributor Author

No no; I just try to keep things trim wherever possible. And as your APK is still inside the per-app size limit, there's no problem to remove the entire app. We may have to reduce the number ov versions we keep, but that's all. Presence in our repo also increases discoverability 😉

@IzzySoft
Copy link
Contributor Author

@cagnulein btw:

ignoring update for org.cagnulein.qzcompanionnordictracktreadmill, versionCode 154 already present

Did you forget to increase versionCode?

@cagnulein
Copy link
Owner

Yes thanks for the heads up!

@stale Stale
Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 1, 2025
@IzzySoft
Copy link
Contributor Author

IzzySoft commented Feb 3, 2025

My thanks to your bot for its constant reminders 🤪

@stale stale bot removed the wontfix This will not be worked on label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cagnulein @IzzySoft