Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows compatibility issue with Url #5

Open
taylortom opened this issue Jan 7, 2016 · 0 comments
Open

Windows compatibility issue with Url #5

taylortom opened this issue Jan 7, 2016 · 0 comments

Comments

@taylortom
Copy link

makeRelative doesn't work if mixing slashes.

Had a problem with the build process whereby we were looking for a windows escaped base URL in a *nix path.
i.e. something like

C:\Some\Dir\Path\
C:/Some/Dir/Path/File.ext

As Url uses a replace, this won't work, as the slashes conflict.

Have submitted #6 as a working example solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taylortom