From ed3334b1abf0f101f262f5ac3b825b61175df0b7 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Sun, 14 Jul 2024 23:27:44 +0200 Subject: [PATCH 1/9] Switch to releasing on GH-Actions also: - disable posting to gitter - disable codecov - update GRM to the newest 0.18.0 --- .github/workflows/build.yml | 3 +-- recipe.cake | 9 ++++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3f0c231..48f0a96 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -19,11 +19,9 @@ jobs: AZURE_SOURCE: ${{ secrets.AZURE_SOURCE }} AZURE_USER: ${{ secrets.AZURE_USER }} GITHUB_PAT: ${{ secrets.GH_TOKEN }} - GITTER_ROOM_ID: ${{ secrets.GITTER_ROOM_ID }} GPR_PASSWORD: ${{ secrets.GPR_PASSWORD }} GPR_SOURCE: ${{ secrets.GPR_SOURCE }} GPR_USER: ${{ secrets.GPR_USER }} - GITTER_TOKEN: ${{ secrets.GITTER_TOKEN }} NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }} NUGET_SOURCE: "https://api.nuget.org/v3/index.json" TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }} @@ -33,6 +31,7 @@ jobs: WYAM_ACCESS_TOKEN: ${{ secrets.WYAM_ACCESS_TOKEN }} WYAM_DEPLOY_BRANCH: "gh-pages" WYAM_DEPLOY_REMOTE: ${{ github.event.repository.html_url }} + steps: - name: Checkout the repository uses: actions/checkout@v2 diff --git a/recipe.cake b/recipe.cake index e2d6c61..7069fa7 100644 --- a/recipe.cake +++ b/recipe.cake @@ -8,10 +8,17 @@ BuildParameters.SetParameters(context: Context, title: "Cake.Discord", repositoryOwner: "cake-contrib", repositoryName: "Cake.Discord", - appVeyorAccountName: "cakecontrib"); + appVeyorAccountName: "cakecontrib", + shouldRunCodecov: false, + shouldPostToGitter: false, + preferredBuildProviderType: BuildProviderType.GitHubActions, + preferredBuildAgentOperatingSystem: PlatformFamily.Windows); BuildParameters.PrintParameters(Context); +ToolSettings.SetToolPreprocessorDirectives( + gitReleaseManagerGlobalTool: "#tool dotnet:?package=GitReleaseManager.Tool&version=0.18.0"); + ToolSettings.SetToolSettings(context: Context, dupFinderExcludePattern: new string[] { BuildParameters.RootDirectoryPath + "/Source/Cake.Discord/**/*.AssemblyInfo.cs", From 41f37b82d2c0aa364fee23b5cd65674c0d2c2065 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Sun, 14 Jul 2024 23:29:08 +0200 Subject: [PATCH 2/9] add settings.json for vscode --- .vscode/settings.json | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .vscode/settings.json diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 0000000..a208e6c --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,8 @@ +{ + "omnisharp.enableEditorConfigSupport": true, + "omnisharp.enableRoslynAnalyzers": true, + "[powershell]": { + "files.encoding": "utf8bom" + }, + "powershell.codeFormatting.addWhitespaceAroundPipe": true + } \ No newline at end of file From 95887ab0b61bdb3ebe8c8ff22b12b9c6b87820a6 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 08:11:24 +0200 Subject: [PATCH 3/9] Remove usage of nuspec file(s) for NuGet packages --- Source/Cake.Discord/Cake.Discord.csproj | 26 +++++++++++++++++-------- Source/Directory.Build.props | 5 +++++ nuspec/nuget/Cake.Discord.nuspec | 26 ------------------------- recipe.cake | 1 + 4 files changed, 24 insertions(+), 34 deletions(-) create mode 100644 Source/Directory.Build.props delete mode 100644 nuspec/nuget/Cake.Discord.nuspec diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index de9c9cb..345de5e 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -4,19 +4,29 @@ net46;netstandard2.0 true true + $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb + NU5048 - - bin\Debug\net46\Cake.Discord.xml - - - - bin\Release\net46\Cake.Discord.xml + + + Gary Ewan Park + Copyright (c) Cake Contributions 2018 - Present + Cake AddIn that extends Cake with ability to send messages to Discord. +This version was build for Cake v$(CakeVersion) + MIT + https://github.com/cake-contrib/Cake.Discord + cake;script;Build;Discord + $(PackageProjectUrl).git + This version was build for Cake v$(CakeVersion). +For details see $(PackageProjectUrl)/releases + 0.0.0 + https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png - - + + diff --git a/Source/Directory.Build.props b/Source/Directory.Build.props new file mode 100644 index 0000000..35525a1 --- /dev/null +++ b/Source/Directory.Build.props @@ -0,0 +1,5 @@ + + + 0.33.0 + + \ No newline at end of file diff --git a/nuspec/nuget/Cake.Discord.nuspec b/nuspec/nuget/Cake.Discord.nuspec deleted file mode 100644 index c2e7dd3..0000000 --- a/nuspec/nuget/Cake.Discord.nuspec +++ /dev/null @@ -1,26 +0,0 @@ - - - - Cake.Discord - 0.0.0 - gep13 - gep13, cake-contrib - Cake Discord AddIn. - Cake AddIn that extends Cake with ability to send messages to Discord. - MIT - - https://github.com/cake-contrib/Cake.Discord/ - false - https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png - Copyright (c) Cake Contributions 2018 - Present - Cake, Script, Build, Discord - - - - - - - - - - diff --git a/recipe.cake b/recipe.cake index 7069fa7..02f0661 100644 --- a/recipe.cake +++ b/recipe.cake @@ -9,6 +9,7 @@ BuildParameters.SetParameters(context: Context, repositoryOwner: "cake-contrib", repositoryName: "Cake.Discord", appVeyorAccountName: "cakecontrib", + shouldRunDotNetCorePack: true, shouldRunCodecov: false, shouldPostToGitter: false, preferredBuildProviderType: BuildProviderType.GitHubActions, From 7fe559172f4a46bcc0f8af0d12df0a355c2733fd Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 08:29:12 +0200 Subject: [PATCH 4/9] Add Cake.Addin.Analyzer package --- Source/Cake.Discord/Cake.Discord.csproj | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index 345de5e..28ed663 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -25,6 +25,10 @@ For details see $(PackageProjectUrl)/releases + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + From 00d9b96c1fc24e76661d940c5ae3d5a5678a84a1 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 08:32:23 +0200 Subject: [PATCH 5/9] Add CakeContrib.Guidelines Nuget Package This automatically solves: Use embedded icon for NuGet package --- Source/Cake.Discord/Cake.Discord.csproj | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index 28ed663..617ec16 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -5,7 +5,6 @@ true true $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb - NU5048 @@ -21,7 +20,6 @@ This version was build for Cake v$(CakeVersion) This version was build for Cake v$(CakeVersion). For details see $(PackageProjectUrl)/releases 0.0.0 - https://cdn.jsdelivr.net/gh/cake-contrib/graphics/png/cake-contrib-medium.png @@ -31,6 +29,10 @@ For details see $(PackageProjectUrl)/releases + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + From 5948f09c27adce5baf53a17de8d234829f95097e Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 08:33:44 +0200 Subject: [PATCH 6/9] fixed CCG0008 --- Source/Cake.Discord/Cake.Discord.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index 617ec16..8bea6f0 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -15,7 +15,7 @@ This version was build for Cake v$(CakeVersion) MIT https://github.com/cake-contrib/Cake.Discord - cake;script;Build;Discord + cake;script;build;discord;cake-addin;addin;cake-build $(PackageProjectUrl).git This version was build for Cake v$(CakeVersion). For details see $(PackageProjectUrl)/releases From c66db8100b7dfc90c2c195c61fd7e48ba6586ba7 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 08:36:35 +0200 Subject: [PATCH 7/9] disabled CCG0009 --- Source/Cake.Discord/Cake.Discord.csproj | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index 8bea6f0..994bcca 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -7,6 +7,12 @@ $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb + + + + + + Gary Ewan Park From d59426cc66c8a3019e0630868af91970e8cb6159 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 10:53:44 +0200 Subject: [PATCH 8/9] fixed CCG0005 by adding a reference to stylecop - Also, added a stylecop.json and .editorconfig - Fixed all stylecop issues in the code (mostly documentation) - Exempted LitJson from all rules, by liberally sprinkling pragmas. --- .editorconfig | 10 +- Source/.editorconfig | 241 ++++++++++++++++++ Source/Cake.Discord.ruleset | 7 + Source/Cake.Discord/Cake.Discord.csproj | 14 +- Source/Cake.Discord/Chat/DiscordChatApi.cs | 13 +- .../Chat/DiscordChatMessageResult.cs | 44 ++-- .../Chat/DiscordChatMessageSettings.cs | 10 +- .../Cake.Discord/Chat/DiscordChatProvider.cs | 44 ++-- Source/Cake.Discord/DiscordAliases.cs | 10 +- Source/Cake.Discord/DiscordProvider.cs | 16 +- Source/Cake.Discord/LitJson/IJsonWrapper.cs | 82 ++++++ Source/Cake.Discord/LitJson/JsonData.cs | 83 ++++++ Source/Cake.Discord/LitJson/JsonException.cs | 83 ++++++ Source/Cake.Discord/LitJson/JsonMapper.cs | 83 ++++++ .../Cake.Discord/LitJson/JsonMockWrapper.cs | 82 ++++++ Source/Cake.Discord/LitJson/JsonReader.cs | 82 ++++++ Source/Cake.Discord/LitJson/JsonWriter.cs | 82 ++++++ Source/Cake.Discord/LitJson/Lexer.cs | 82 ++++++ Source/Cake.Discord/LitJson/ParserToken.cs | 82 ++++++ Source/stylecop.json | 22 ++ 20 files changed, 1095 insertions(+), 77 deletions(-) create mode 100644 Source/.editorconfig create mode 100644 Source/Cake.Discord.ruleset create mode 100644 Source/stylecop.json diff --git a/.editorconfig b/.editorconfig index 1172014..0aae7a9 100644 --- a/.editorconfig +++ b/.editorconfig @@ -5,12 +5,14 @@ root = true [*] end_of_line = CRLF +trim_trailing_whitespace = true -[*.ps1] -indent_style = space -indent_size = 4 +[*.md] +trim_trailing_whitespace = false -[*.cs] +[*.{bat,ps1}] +charset = utf-8-bom +end_of_line = crlf indent_style = space indent_size = 4 diff --git a/Source/.editorconfig b/Source/.editorconfig new file mode 100644 index 0000000..be3351d --- /dev/null +++ b/Source/.editorconfig @@ -0,0 +1,241 @@ + +# This may not be needed, but kept for compatibility with VS +[*.{sln,csproj}] +end_of_line = crlf +indent_size = 2 + +# C# files +[*.cs] + +#### Core EditorConfig Options #### + +# Indentation and spacing +indent_size = 4 +indent_style = space +tab_width = 4 + +# New line preferences +end_of_line = crlf +insert_final_newline = true + +#### .NET Coding Conventions #### + +# Organize usings +dotnet_separate_import_directive_groups = true +dotnet_sort_system_directives_first = true +file_header_template = unset + +# this. and Me. preferences +dotnet_style_qualification_for_event = false:warning +dotnet_style_qualification_for_field = false:warning +dotnet_style_qualification_for_method = false:warning +dotnet_style_qualification_for_property = false:warning + +# Language keywords vs BCL types preferences +dotnet_style_predefined_type_for_locals_parameters_members = true:warning +dotnet_style_predefined_type_for_member_access = true:warning + +# Parentheses preferences +dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:silent +dotnet_style_parentheses_in_other_binary_operators = always_for_clarity:silent +dotnet_style_parentheses_in_other_operators = never_if_unnecessary:silent +dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity:silent + +# Modifier preferences +dotnet_style_require_accessibility_modifiers = for_non_interface_members:warning + +# Expression-level preferences +dotnet_style_coalesce_expression = true:suggestion +dotnet_style_collection_initializer = true:suggestion +dotnet_style_explicit_tuple_names = true:suggestion +dotnet_style_null_propagation = true:suggestion +dotnet_style_object_initializer = true:suggestion +dotnet_style_operator_placement_when_wrapping = beginning_of_line +dotnet_style_prefer_auto_properties = true:silent +dotnet_style_prefer_compound_assignment = true:suggestion +dotnet_style_prefer_conditional_expression_over_assignment = true:silent +dotnet_style_prefer_conditional_expression_over_return = true:silent +dotnet_style_prefer_inferred_anonymous_type_member_names = true:suggestion +dotnet_style_prefer_inferred_tuple_names = true:suggestion +dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion +dotnet_style_prefer_simplified_boolean_expressions = true:suggestion +dotnet_style_prefer_simplified_interpolation = true:suggestion + +# Field preferences +dotnet_style_readonly_field = true:suggestion + +# Parameter preferences +dotnet_code_quality_unused_parameters = all:suggestion + +#### C# Coding Conventions #### + +# var preferences +csharp_style_var_elsewhere = false:silent +csharp_style_var_for_built_in_types = false:silent +csharp_style_var_when_type_is_apparent = false:silent + +# Expression-bodied members +csharp_style_expression_bodied_accessors = true:silent +csharp_style_expression_bodied_constructors = false:silent +csharp_style_expression_bodied_indexers = true:silent +csharp_style_expression_bodied_lambdas = true:silent +csharp_style_expression_bodied_local_functions = false:silent +csharp_style_expression_bodied_methods = false:silent +csharp_style_expression_bodied_operators = false:silent +csharp_style_expression_bodied_properties = true:silent + +# Pattern matching preferences +csharp_style_pattern_matching_over_as_with_null_check = true:suggestion +csharp_style_pattern_matching_over_is_with_cast_check = true:suggestion +csharp_style_prefer_switch_expression = true:suggestion + +# Null-checking preferences +csharp_style_conditional_delegate_call = true:suggestion + +# Modifier preferences +csharp_prefer_static_local_function = true:suggestion +csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async:silent + +# Code-block preferences +csharp_prefer_braces = true:silent +csharp_prefer_simple_using_statement = true:suggestion + +# Expression-level preferences +csharp_prefer_simple_default_expression = true:suggestion +csharp_style_deconstructed_variable_declaration = true:suggestion +csharp_style_inlined_variable_declaration = true:suggestion +csharp_style_pattern_local_over_anonymous_function = true:suggestion +csharp_style_prefer_index_operator = true:suggestion +csharp_style_prefer_range_operator = true:suggestion +csharp_style_throw_expression = true:suggestion +csharp_style_unused_value_assignment_preference = discard_variable:suggestion +csharp_style_unused_value_expression_statement_preference = discard_variable:silent + +# 'using' directive preferences +csharp_using_directive_placement = outside_namespace:warning + +#### C# Formatting Rules #### + +# New line preferences +csharp_new_line_before_catch = true +csharp_new_line_before_else = true +csharp_new_line_before_finally = true +csharp_new_line_before_members_in_anonymous_types = true +csharp_new_line_before_members_in_object_initializers = true +csharp_new_line_before_open_brace = all +csharp_new_line_between_query_expression_clauses = true + +# Indentation preferences +csharp_indent_block_contents = true +csharp_indent_braces = false +csharp_indent_case_contents = true +csharp_indent_case_contents_when_block = false +csharp_indent_labels = flush_left +csharp_indent_switch_labels = true + +# Space preferences +csharp_space_after_cast = false +csharp_space_after_colon_in_inheritance_clause = true +csharp_space_after_comma = true +csharp_space_after_dot = false +csharp_space_after_keywords_in_control_flow_statements = true +csharp_space_after_semicolon_in_for_statement = true +csharp_space_around_binary_operators = before_and_after +csharp_space_around_declaration_statements = false +csharp_space_before_colon_in_inheritance_clause = true +csharp_space_before_comma = false +csharp_space_before_dot = false +csharp_space_before_open_square_brackets = false +csharp_space_before_semicolon_in_for_statement = false +csharp_space_between_empty_square_brackets = false +csharp_space_between_method_call_empty_parameter_list_parentheses = false +csharp_space_between_method_call_name_and_opening_parenthesis = false +csharp_space_between_method_call_parameter_list_parentheses = false +csharp_space_between_method_declaration_empty_parameter_list_parentheses = false +csharp_space_between_method_declaration_name_and_open_parenthesis = false +csharp_space_between_method_declaration_parameter_list_parentheses = false +csharp_space_between_parentheses = false +csharp_space_between_square_brackets = false + +# Wrapping preferences +csharp_preserve_single_line_blocks = true +csharp_preserve_single_line_statements = false + +#### Naming styles #### + +# Naming rules + +dotnet_naming_rule.interface_should_be_begins_with_i.severity = warning +dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface +dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i + +dotnet_naming_rule.types_should_be_pascal_case.severity = warning +dotnet_naming_rule.types_should_be_pascal_case.symbols = types +dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case + +dotnet_naming_rule.method_should_be_pascal_case.severity = warning +dotnet_naming_rule.method_should_be_pascal_case.symbols = method +dotnet_naming_rule.method_should_be_pascal_case.style = pascal_case + +dotnet_naming_rule.public_or_protected_field_should_be_pascal_case.severity = warning +dotnet_naming_rule.public_or_protected_field_should_be_pascal_case.symbols = public_or_protected_field +dotnet_naming_rule.public_or_protected_field_should_be_pascal_case.style = pascal_case + +dotnet_naming_rule.private_or_internal_static_field_should_be_pascal_case.severity = warning +dotnet_naming_rule.private_or_internal_static_field_should_be_pascal_case.symbols = private_or_internal_static_field +dotnet_naming_rule.private_or_internal_static_field_should_be_pascal_case.style = pascal_case + +dotnet_naming_rule.private_or_internal_field_should_be_camelcase.severity = warning +dotnet_naming_rule.private_or_internal_field_should_be_camelcase.symbols = private_or_internal_field +dotnet_naming_rule.private_or_internal_field_should_be_camelcase.style = camelcase + +dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = warning +dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members +dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case + +# Symbol specifications + +dotnet_naming_symbols.interface.applicable_kinds = interface +dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected +dotnet_naming_symbols.interface.required_modifiers = + +dotnet_naming_symbols.method.applicable_kinds = method +dotnet_naming_symbols.method.applicable_accessibilities = public +dotnet_naming_symbols.method.required_modifiers = + +dotnet_naming_symbols.public_or_protected_field.applicable_kinds = field +dotnet_naming_symbols.public_or_protected_field.applicable_accessibilities = public, protected +dotnet_naming_symbols.public_or_protected_field.required_modifiers = + +dotnet_naming_symbols.private_or_internal_field.applicable_kinds = field +dotnet_naming_symbols.private_or_internal_field.applicable_accessibilities = internal, private, private_protected +dotnet_naming_symbols.private_or_internal_field.required_modifiers = + +dotnet_naming_symbols.private_or_internal_static_field.applicable_kinds = field +dotnet_naming_symbols.private_or_internal_static_field.applicable_accessibilities = internal, private, private_protected +dotnet_naming_symbols.private_or_internal_static_field.required_modifiers = static + +dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum +dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected +dotnet_naming_symbols.types.required_modifiers = + +dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method +dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected +dotnet_naming_symbols.non_field_members.required_modifiers = + +# Naming styles + +dotnet_naming_style.pascal_case.required_prefix = +dotnet_naming_style.pascal_case.required_suffix = +dotnet_naming_style.pascal_case.word_separator = +dotnet_naming_style.pascal_case.capitalization = pascal_case + +dotnet_naming_style.begins_with_i.required_prefix = I +dotnet_naming_style.begins_with_i.required_suffix = +dotnet_naming_style.begins_with_i.word_separator = +dotnet_naming_style.begins_with_i.capitalization = pascal_case + +dotnet_naming_style.camelcase.required_prefix = +dotnet_naming_style.camelcase.required_suffix = +dotnet_naming_style.camelcase.word_separator = +dotnet_naming_style.camelcase.capitalization = camel_case \ No newline at end of file diff --git a/Source/Cake.Discord.ruleset b/Source/Cake.Discord.ruleset new file mode 100644 index 0000000..24b79b5 --- /dev/null +++ b/Source/Cake.Discord.ruleset @@ -0,0 +1,7 @@ + + + + + + + \ No newline at end of file diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index 994bcca..00b9372 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -5,14 +5,20 @@ true true $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb + $(ProjectDir)../Cake.Discord.ruleset - + + + + + + - + Gary Ewan Park @@ -39,6 +45,10 @@ For details see $(PackageProjectUrl)/releases all runtime; build; native; contentfiles; analyzers; buildtransitive + + all + runtime; build; native; contentfiles; analyzers; buildtransitive + diff --git a/Source/Cake.Discord/Chat/DiscordChatApi.cs b/Source/Cake.Discord/Chat/DiscordChatApi.cs index dc8fe93..e8f802e 100644 --- a/Source/Cake.Discord/Chat/DiscordChatApi.cs +++ b/Source/Cake.Discord/Chat/DiscordChatApi.cs @@ -1,8 +1,6 @@ using System; -using System.Collections.Generic; using System.Linq; using System.Net.Http; -using System.Net.Http.Headers; using System.Text; using System.Threading.Tasks; using Cake.Common.Diagnostics; @@ -36,9 +34,7 @@ internal static async Task PostMessage( .TrimEnd('/') .Reverse() .SkipWhile(c => c != '/') - .Reverse() - ) - ); + .Reverse())); var json = ToJson( new @@ -46,7 +42,7 @@ internal static async Task PostMessage( content, username = messageSettings.UserName ?? "CakeBuild", avatar_url = messageSettings.AvatarUrl?.ToString() ?? new Uri("https://raw.githubusercontent.com/cake-build/graphics/master/png/cake-small.png").ToString(), - tts = messageSettings.Tts + tts = messageSettings.Tts, }); context.Debug("Parameter: {0}", json); @@ -59,7 +55,8 @@ internal static async Task PostMessage( context.Debug($"Status Code: {httpResponse.StatusCode}"); DiscordChatMessageResult parsedResult = null; - if(httpResponse.StatusCode != System.Net.HttpStatusCode.NoContent) + + if (httpResponse.StatusCode != System.Net.HttpStatusCode.NoContent) { var response = await httpResponse.Content.ReadAsStringAsync(); context.Debug($"Response: {response}"); @@ -110,7 +107,7 @@ private static string ToJson(object obj) { var jsonWriter = new JsonWriter { - LowerCaseProperties = true + LowerCaseProperties = true, }; JsonMapper.ToJson(obj, jsonWriter); return jsonWriter.ToString(); diff --git a/Source/Cake.Discord/Chat/DiscordChatMessageResult.cs b/Source/Cake.Discord/Chat/DiscordChatMessageResult.cs index 74ded50..64432ba 100644 --- a/Source/Cake.Discord/Chat/DiscordChatMessageResult.cs +++ b/Source/Cake.Discord/Chat/DiscordChatMessageResult.cs @@ -9,50 +9,50 @@ namespace Cake.Discord.Chat { /// - /// The result of DiscordProvider Chat API post + /// The result of DiscordProvider Chat API post. /// [CakeAliasCategory("Discord")] public sealed class DiscordChatMessageResult { /// - /// Indicating success or failure, for info on failure + /// Initializes a new instance of the class. + /// + /// Indicating success or failure. + /// Timestamp of the message. + /// Error code on failure. + /// Error message on failure. + public DiscordChatMessageResult(bool ok, string timeStamp, int errorCode, string error) + { + Ok = ok; + TimeStamp = timeStamp; + ErrorCode = errorCode; + Error = error; + } + + /// + /// Gets a value indicating whether the result is a success or failure, for info on failure. /// public bool Ok { get; } /// - /// Timestamp of the message + /// Gets the timestamp of the message. /// public string TimeStamp { get; } /// - /// Error code on failure + /// Gets the error code on failure. /// public int ErrorCode { get; } /// - /// Error message on failure + /// Gets the error message on failure. /// public string Error { get; } /// - /// - /// - /// Indicating success or failure - /// Timestamp of the message - /// Error code on failure - /// Error message on failure - public DiscordChatMessageResult(bool ok, string timeStamp, int errorCode, string error) - { - Ok = ok; - TimeStamp = timeStamp; - ErrorCode = errorCode; - Error = error; - } - - /// - /// Converts this instance of value to a string representation + /// Converts this instance of value to a string representation. /// - /// + /// The string representation. public override string ToString() { var builder = new StringBuilder(); diff --git a/Source/Cake.Discord/Chat/DiscordChatMessageSettings.cs b/Source/Cake.Discord/Chat/DiscordChatMessageSettings.cs index 628f3b0..f810ca5 100644 --- a/Source/Cake.Discord/Chat/DiscordChatMessageSettings.cs +++ b/Source/Cake.Discord/Chat/DiscordChatMessageSettings.cs @@ -9,29 +9,29 @@ namespace Cake.Discord.Chat { /// - /// Class that lets you override default API settings + /// Class that lets you override default API settings. /// [CakeAliasCategory("Discord")] public sealed class DiscordChatMessageSettings { /// - /// Name of bot. + /// Gets or sets the name of the bot. /// public string UserName { get; set; } /// - /// URL to an image to use as the avatar for this message + /// Gets or sets the URL to an image to use as the avatar for this message. /// public Uri AvatarUrl { get; set; } /// /// Gets or sets a value indicating whether this message is a - /// Text to Speech message + /// Text to Speech message. /// public bool Tts { get; set; } /// - /// Optional flag for if should throw exception on failure + /// Gets or sets whether to throw an exception on failure. /// public bool? ThrowOnFail { get; set; } } diff --git a/Source/Cake.Discord/Chat/DiscordChatProvider.cs b/Source/Cake.Discord/Chat/DiscordChatProvider.cs index 6623a25..51eaab8 100644 --- a/Source/Cake.Discord/Chat/DiscordChatProvider.cs +++ b/Source/Cake.Discord/Chat/DiscordChatProvider.cs @@ -1,5 +1,4 @@ using System; -using System.Collections.Generic; using Cake.Core; using Cake.Core.Annotations; @@ -12,14 +11,23 @@ namespace Cake.Discord.Chat [CakeAliasCategory("Discord")] public sealed class DiscordChatProvider { - private readonly ICakeContext _context; + private readonly ICakeContext context; /// - /// Post message to Discord WebHook + /// Initializes a new instance of the class. /// - /// The URL for the webhook that messages should be sent to. + /// The context. + public DiscordChatProvider(ICakeContext context) + { + this.context = context; + } + + /// + /// Post message to Discord WebHook. + /// + /// The URL for the webhook that messages should be sent to. /// Content of the message to send. - /// Returns success/errorcode/error/timestamp + /// Returns success/errorcode/error/timestamp . /// /// /// Information("This is a 'normal' message..."); @@ -42,26 +50,24 @@ public sealed class DiscordChatProvider [CakeAliasCategory("Chat")] public DiscordChatMessageResult PostMessage( string webHookUrl, - string content - ) + string content) { - var response = _context.PostMessage( + var response = context.PostMessage( webHookUrl, content, - new DiscordChatMessageSettings() - ); + new DiscordChatMessageSettings()); response.Wait(); return response.Result; } /// - /// Post message to Discord WebHook + /// Post message to Discord WebHook. /// /// The URL for the webhook that messages should be sent to. /// Content of the message to send. /// Lets you override default settings like UserName, or IconUrl. - /// Returns success/error/timestamp + /// Returns success/error/timestamp . /// /// /// Information("This is a custom avatar and name message..."); @@ -89,15 +95,14 @@ string content public DiscordChatMessageResult PostMessage( string webHookUrl, string content, - DiscordChatMessageSettings messageSettings - ) + DiscordChatMessageSettings messageSettings) { if (messageSettings == null) { throw new ArgumentNullException(nameof(messageSettings)); } - var response = _context.PostMessage( + var response = context.PostMessage( webHookUrl, content, messageSettings); @@ -106,14 +111,5 @@ DiscordChatMessageSettings messageSettings return response.Result; } - - /// - /// Initializes a new instance of the class. - /// - /// The context. - public DiscordChatProvider(ICakeContext context) - { - _context = context; - } } } diff --git a/Source/Cake.Discord/DiscordAliases.cs b/Source/Cake.Discord/DiscordAliases.cs index 3f3a675..348579e 100644 --- a/Source/Cake.Discord/DiscordAliases.cs +++ b/Source/Cake.Discord/DiscordAliases.cs @@ -2,13 +2,14 @@ using Cake.Core; using Cake.Core.Annotations; +// ReSharper disable UnusedType.Global +// ReSharper disable UnusedMember.Global namespace Cake.Discord { /// - /// Contains aliases related to DiscordS API + /// Contains aliases related to DiscordS API. /// [CakeAliasCategory("Discord")] - // ReSharper disable once UnusedMember.Global public static class DiscordAliases { /// @@ -17,14 +18,15 @@ public static class DiscordAliases /// The context. /// A instance. [CakePropertyAlias(Cache = true)] - [CakeNamespaceImportAttribute("Cake.Discord.Chat")] - // ReSharper disable once UnusedMember.Global + [CakeNamespaceImport("Cake.Discord.Chat")] + public static DiscordProvider Discord(this ICakeContext context) { if (context == null) { throw new ArgumentNullException(nameof(context)); } + return new DiscordProvider(context); } } diff --git a/Source/Cake.Discord/DiscordProvider.cs b/Source/Cake.Discord/DiscordProvider.cs index 666512f..022c54b 100644 --- a/Source/Cake.Discord/DiscordProvider.cs +++ b/Source/Cake.Discord/DiscordProvider.cs @@ -4,17 +4,10 @@ namespace Cake.Discord { /// - /// Contains functionality related to Discord API + /// Contains functionality related to Discord API. /// public sealed class DiscordProvider { - /// - /// The Discord Chat functionality. - /// - // ReSharper disable once UnusedAutoPropertyAccessor.Global - // ReSharper disable once MemberCanBePrivate.Global - public DiscordChatProvider Chat { get; } - /// /// Initializes a new instance of the class. /// @@ -23,5 +16,12 @@ public DiscordProvider(ICakeContext context) { Chat = new DiscordChatProvider(context); } + + /// + /// Gets the Discord Chat functionality. + /// + // ReSharper disable once UnusedAutoPropertyAccessor.Global + // ReSharper disable once MemberCanBePrivate.Global + public DiscordChatProvider Chat { get; } } } diff --git a/Source/Cake.Discord/LitJson/IJsonWrapper.cs b/Source/Cake.Discord/LitJson/IJsonWrapper.cs index 3b3f094..4b1c9cd 100644 --- a/Source/Cake.Discord/LitJson/IJsonWrapper.cs +++ b/Source/Cake.Discord/LitJson/IJsonWrapper.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* @@ -12,6 +13,46 @@ #endregion Header +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System.Collections; @@ -75,3 +116,44 @@ internal interface IJsonWrapper : IList, IOrderedDictionary } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 diff --git a/Source/Cake.Discord/LitJson/JsonData.cs b/Source/Cake.Discord/LitJson/JsonData.cs index 9d46c14..79138c3 100644 --- a/Source/Cake.Discord/LitJson/JsonData.cs +++ b/Source/Cake.Discord/LitJson/JsonData.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * JsonData.cs @@ -9,6 +10,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -1101,3 +1142,45 @@ public void Reset() } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 + diff --git a/Source/Cake.Discord/LitJson/JsonException.cs b/Source/Cake.Discord/LitJson/JsonException.cs index e251c38..951def6 100644 --- a/Source/Cake.Discord/LitJson/JsonException.cs +++ b/Source/Cake.Discord/LitJson/JsonException.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * JsonException.cs @@ -8,6 +9,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -60,3 +101,45 @@ public JsonException(string message, Exception inner_exception) : } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 + diff --git a/Source/Cake.Discord/LitJson/JsonMapper.cs b/Source/Cake.Discord/LitJson/JsonMapper.cs index bea8810..39bfe32 100644 --- a/Source/Cake.Discord/LitJson/JsonMapper.cs +++ b/Source/Cake.Discord/LitJson/JsonMapper.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * JsonMapper.cs @@ -10,6 +11,46 @@ using System.Linq; +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1402 +#pragma warning disable SA1401 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -1053,3 +1094,45 @@ public static void UnregisterImporters() } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 + diff --git a/Source/Cake.Discord/LitJson/JsonMockWrapper.cs b/Source/Cake.Discord/LitJson/JsonMockWrapper.cs index 1e9743e..1e35a63 100644 --- a/Source/Cake.Discord/LitJson/JsonMockWrapper.cs +++ b/Source/Cake.Discord/LitJson/JsonMockWrapper.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * JsonMockWrapper.cs @@ -9,6 +10,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -263,3 +304,44 @@ void IOrderedDictionary.RemoveAt(int i) } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 diff --git a/Source/Cake.Discord/LitJson/JsonReader.cs b/Source/Cake.Discord/LitJson/JsonReader.cs index f45d069..e8bd992 100644 --- a/Source/Cake.Discord/LitJson/JsonReader.cs +++ b/Source/Cake.Discord/LitJson/JsonReader.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * JsonReader.cs @@ -8,6 +9,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -531,3 +572,44 @@ public bool Read() } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 diff --git a/Source/Cake.Discord/LitJson/JsonWriter.cs b/Source/Cake.Discord/LitJson/JsonWriter.cs index 0c8f42f..fd330bf 100644 --- a/Source/Cake.Discord/LitJson/JsonWriter.cs +++ b/Source/Cake.Discord/LitJson/JsonWriter.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * JsonWriter.cs @@ -8,6 +9,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -496,3 +537,44 @@ public void WritePropertyName(string property_name) } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 diff --git a/Source/Cake.Discord/LitJson/Lexer.cs b/Source/Cake.Discord/LitJson/Lexer.cs index b76a3ad..d437a87 100644 --- a/Source/Cake.Discord/LitJson/Lexer.cs +++ b/Source/Cake.Discord/LitJson/Lexer.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * Lexer.cs @@ -8,6 +9,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { using System; @@ -981,3 +1022,44 @@ private void UngetChar() } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 diff --git a/Source/Cake.Discord/LitJson/ParserToken.cs b/Source/Cake.Discord/LitJson/ParserToken.cs index 7debb95..61ba06b 100644 --- a/Source/Cake.Discord/LitJson/ParserToken.cs +++ b/Source/Cake.Discord/LitJson/ParserToken.cs @@ -1,3 +1,4 @@ +#pragma warning disable SA1124 #region Header /* * ParserToken.cs @@ -8,6 +9,46 @@ */ #endregion +#pragma warning disable SA1003 +#pragma warning disable SA1008 +#pragma warning disable SA1009 +#pragma warning disable SA1012 +#pragma warning disable SA1013 +#pragma warning disable SA1115 +#pragma warning disable SA1116 +#pragma warning disable SA1117 +#pragma warning disable SA1119 +#pragma warning disable SA1121 +#pragma warning disable SA1122 +#pragma warning disable SA1128 +#pragma warning disable SA1129 +#pragma warning disable SA1130 +#pragma warning disable SA1200 +#pragma warning disable SA1201 +#pragma warning disable SA1202 +#pragma warning disable SA1204 +#pragma warning disable SA1210 +#pragma warning disable SA1310 +#pragma warning disable SA1311 +#pragma warning disable SA1400 +#pragma warning disable SA1401 +#pragma warning disable SA1402 +#pragma warning disable SA1403 +#pragma warning disable SA1408 +#pragma warning disable SA1413 +#pragma warning disable SA1500 +#pragma warning disable SA1503 +#pragma warning disable SA1504 +#pragma warning disable SA1507 +#pragma warning disable SA1505 +#pragma warning disable SA1508 +#pragma warning disable SA1513 +#pragma warning disable SA1515 +#pragma warning disable SA1516 +#pragma warning disable SA1519 +#pragma warning disable SA1520 +#pragma warning disable SA1600 +#pragma warning disable SA1649 namespace Cake.Discord { namespace LitJson @@ -44,3 +85,44 @@ internal enum ParserToken } } } +#pragma warning restore SA1003 +#pragma warning restore SA1008 +#pragma warning restore SA1009 +#pragma warning restore SA1012 +#pragma warning restore SA1013 +#pragma warning restore SA1115 +#pragma warning restore SA1116 +#pragma warning restore SA1117 +#pragma warning restore SA1119 +#pragma warning restore SA1121 +#pragma warning restore SA1122 +#pragma warning restore SA1124 +#pragma warning restore SA1128 +#pragma warning restore SA1129 +#pragma warning restore SA1130 +#pragma warning restore SA1200 +#pragma warning restore SA1201 +#pragma warning restore SA1202 +#pragma warning restore SA1204 +#pragma warning restore SA1210 +#pragma warning restore SA1310 +#pragma warning restore SA1311 +#pragma warning restore SA1400 +#pragma warning restore SA1401 +#pragma warning restore SA1402 +#pragma warning restore SA1403 +#pragma warning restore SA1408 +#pragma warning restore SA1413 +#pragma warning restore SA1500 +#pragma warning restore SA1503 +#pragma warning restore SA1504 +#pragma warning restore SA1507 +#pragma warning restore SA1505 +#pragma warning restore SA1508 +#pragma warning restore SA1513 +#pragma warning restore SA1515 +#pragma warning restore SA1516 +#pragma warning restore SA1519 +#pragma warning restore SA1520 +#pragma warning restore SA1600 +#pragma warning restore SA1649 diff --git a/Source/stylecop.json b/Source/stylecop.json new file mode 100644 index 0000000..3d7a981 --- /dev/null +++ b/Source/stylecop.json @@ -0,0 +1,22 @@ +{ + "$schema": "https://raw.githubusercontent.com/DotNetAnalyzers/StyleCopAnalyzers/master/StyleCop.Analyzers/StyleCop.Analyzers/Settings/stylecop.schema.json", + "settings": { + "indentation": { + "indentationSize": 4, + "tabSize": 4, + "useTabs": false + }, + "orderingRules": { + "usingDirectivesPlacement": "outsideNamespace", + "blankLinesBetweenUsingGroups": "allow", + "systemUsingDirectivesFirst": true + }, + "documentationRules": { + "xmlHeader": false, + "documentExposedElements": true, + "documentInternalElements": false, + "documentPrivateElements": false, + "documentPrivateFields": false + } + } +} \ No newline at end of file From a3455e3a4ffbd30578571595519acc72348987f3 Mon Sep 17 00:00:00 2001 From: Nils Andresen Date: Mon, 15 Jul 2024 11:05:16 +0200 Subject: [PATCH 9/9] Enable deterministic builds --- Source/Cake.Discord/Cake.Discord.csproj | 4 ++++ Source/Directory.Build.targets | 26 +++++++++++++++++++++++++ 2 files changed, 30 insertions(+) create mode 100644 Source/Directory.Build.targets diff --git a/Source/Cake.Discord/Cake.Discord.csproj b/Source/Cake.Discord/Cake.Discord.csproj index 00b9372..0c34b40 100644 --- a/Source/Cake.Discord/Cake.Discord.csproj +++ b/Source/Cake.Discord/Cake.Discord.csproj @@ -45,6 +45,10 @@ For details see $(PackageProjectUrl)/releases all runtime; build; native; contentfiles; analyzers; buildtransitive + + runtime; build; native; contentfiles; analyzers; buildtransitive + all + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/Source/Directory.Build.targets b/Source/Directory.Build.targets new file mode 100644 index 0000000..e0b7d22 --- /dev/null +++ b/Source/Directory.Build.targets @@ -0,0 +1,26 @@ + + + + + + true + true + $([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)')) + + + + + + + + + + + <_LocalTopLevelSourceRoot Include="@(SourceRoot)" Condition="'%(SourceRoot.NestedRoot)' == ''"/> + + +