Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to use command line Git instead of Cake.Git #183

Closed
pascalberger opened this issue Jun 21, 2021 · 4 comments · Fixed by #205
Closed

Provide option to use command line Git instead of Cake.Git #183

pascalberger opened this issue Jun 21, 2021 · 4 comments · Fixed by #205
Labels
Milestone

Comments

@pascalberger
Copy link
Member

Cake.Git addin, which uses LibGit2Sharp, can have issues on certain environments. There should be an option which allows to use Cake.Issues.Recipe without Cake.Git but calls to Git command line instead.

@nils-a
Copy link

nils-a commented Jun 21, 2021

Wouldn't it be more prudent to create a Cake.GitClient, which does not rely on LibGit2Sharp but rather on an existing git command line client.
Those "problems" of LibGit2Sharp are inherent to more systems than Cake.Issues.Recipe, right?

@pascalberger
Copy link
Member Author

Yes, thought about this. What would be nice is to have an abstraction layer, which is then either implemented using LibGit2Sharp or by calling the command line client. If done across multiple addins, this would mean that we need a Cake.GitInterface addin, defining the interface and one addin implementing the interface for LibGit2Sharp and one for command line client. In the build you then would need to add the interface addin plus one of the implementation addins and register it. This is basically how extensibility is also handled in Cake.Issues, but in this case it probably would be easier to handle all this in a single addin which provides both possibilities.

@pascalberger
Copy link
Member Author

Created issue in cake-contrib/Cake_Git#146 for discussing this further

pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 2, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 2, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 2, 2021
@pascalberger pascalberger added this to the 1.0.0 milestone Aug 2, 2021
@pascalberger pascalberger linked a pull request Aug 2, 2021 that will close this issue
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
@pascalberger
Copy link
Member Author

For the time being, I decided to add an option to Cake.Issues recipe, which can be used to decide it Cake.Git or Git CLI should be used, as there are only 3 calls which are required.

pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
pascalberger added a commit to pascalberger/Cake.Issues.Recipe that referenced this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants