diff --git a/src/Cake.Issues.Reporting.Generic.Tests/Cake.Issues.Reporting.Generic.Tests.csproj b/src/Cake.Issues.Reporting.Generic.Tests/Cake.Issues.Reporting.Generic.Tests.csproj index 32c844c6..fe84db99 100644 --- a/src/Cake.Issues.Reporting.Generic.Tests/Cake.Issues.Reporting.Generic.Tests.csproj +++ b/src/Cake.Issues.Reporting.Generic.Tests/Cake.Issues.Reporting.Generic.Tests.csproj @@ -30,7 +30,7 @@ - + all diff --git a/src/Cake.Issues.Reporting.Generic/Cake.Issues.Reporting.Generic.csproj b/src/Cake.Issues.Reporting.Generic/Cake.Issues.Reporting.Generic.csproj index b0ed8bf1..74fec845 100644 --- a/src/Cake.Issues.Reporting.Generic/Cake.Issues.Reporting.Generic.csproj +++ b/src/Cake.Issues.Reporting.Generic/Cake.Issues.Reporting.Generic.csproj @@ -27,8 +27,8 @@ - - + + all 3.0.0 diff --git a/src/Cake.Issues.Reporting.Generic/IIssueExtensions.cs b/src/Cake.Issues.Reporting.Generic/IIssueExtensions.cs index 8a8d7ad7..eec33630 100644 --- a/src/Cake.Issues.Reporting.Generic/IIssueExtensions.cs +++ b/src/Cake.Issues.Reporting.Generic/IIssueExtensions.cs @@ -141,9 +141,9 @@ public static ExpandoObject GetExpandoObject( fallbackToTextMessageIfMarkdownMessageNotAvailable ? issue.Message(IssueCommentFormat.Markdown) : issue.MessageMarkdown; } - if (fileLinkSettings != null && !string.IsNullOrEmpty(fileLinkSettings.FileLinkPattern)) + if (fileLinkSettings != null) { - result.FileLink = fileLinkSettings.FileLinkPattern.ReplaceIssuePattern(issue); + result.FileLink = fileLinkSettings.GetFileLink(issue); } if (additionalValues != null) diff --git a/src/Cake.Issues.Reporting.Generic/Templates/DxDataGrid.cshtml b/src/Cake.Issues.Reporting.Generic/Templates/DxDataGrid.cshtml index 017e96dc..67495fcb 100644 --- a/src/Cake.Issues.Reporting.Generic/Templates/DxDataGrid.cshtml +++ b/src/Cake.Issues.Reporting.Generic/Templates/DxDataGrid.cshtml @@ -46,7 +46,7 @@ ColumnSortOrder messageSortOrder = ViewBagHelper.ValueOrDefault(ViewBag.MessageSortOder, ColumnSortOrder.Ascending); var groupedColumns = ViewBagHelper.ValueOrDefault(ViewBag.GroupedColumns, new List { ReportColumn.ProviderName }); var sortedColumns = ViewBagHelper.ValueOrDefault(ViewBag.SortedColumns, new List { ReportColumn.PriorityName, ReportColumn.ProjectName, ReportColumn.FileDirectory, ReportColumn.FileName, ReportColumn.Line }); - FileLinkSettings fileLinkSettings = ViewBagHelper.ValueOrDefault(ViewBag.FileLinkSettings, new FileLinkSettings()); + FileLinkSettings fileLinkSettings = ViewBagHelper.ValueOrDefault(ViewBag.FileLinkSettings, null); IdeIntegrationSettings ideIntegrationSettings = ViewBagHelper.ValueOrDefault(ViewBag.IdeIntegrationSettings, null); List additionalColumns = ViewBagHelper.ValueOrDefault(ViewBag.AdditionalColumns, new List()); string jQueryLocation = ViewBagHelper.ValueOrDefault(ViewBag.JQueryLocation, "https://ajax.aspnetcdn.com/ajax/jquery/").Trim(); @@ -417,7 +417,7 @@ @:sortIndex: @sortedColumns.IndexOf(ReportColumn.Line), @:sortOrder: "@lineSortOrder.ToShortString()", } - @if (fileLinkSettings != null && !string.IsNullOrWhiteSpace(fileLinkSettings.FileLinkPattern)) + @if (fileLinkSettings != null) { cellTemplate: function (container, options) {