(GH-18) added depcheck to the pipeline #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's one todo still left in the code: I'm not sure if outputting an error in "enough". We could also |
|
@nils-a how about another parameter? i.e. shouldFailOnError? |
|
@gep13 |
|
@nils-a yip, makes sense to me. I wasn't sold on the name that I came up with, just the idea to make it configurable. |
nils-a
force-pushed
the
feature/GH-18
branch
from
0bb5049 to
1d70a03
Compare
Depcheck will raise warnings. if unused packages are referenced in packages.json. configuration: * shouldRunDepcheck (bool) configures whether to run depcheck at all. Default: true * shouldFailOnDepcheckError (bool) configures whether depcheck errors will break the build or only raise warnings. Default: true. * depcheckArguments (string) arguments to pass to the call of depcheck. Default: ""
nils-a
force-pushed
the
feature/GH-18
branch
from
1d70a03 to
582d48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depcheck will raise warnings. if unused packages are referenced
in packages.json.
configuration:
Default: true
Default: ""
fixes #18