Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of LibGit2Sharp is incompatible with Cake.GitVersioning addin #90

Open
flcdrg opened this issue Jan 15, 2019 · 3 comments
Open

Comments

@flcdrg
Copy link

flcdrg commented Jan 15, 2019

As documented in dotnet/Nerdbank.GitVersioning#288, Cake.Git and Cake.GitVersioning both reference LibGit2Sharp, but if they happen to reference different versions, Cake is unable to compile the build script.

It would be good to upgrade Cake.Git to be on par with Cake.GitVersioning so both latest versions of the addins can be used together.

@pascalberger
Copy link
Member

With #108 Cake.Git was updated to LibGit2Sharp 0.26.0 (latest stable release). But I saw that Cake.GitVersioning in the meantime is using LibGit2Sharp 0.27.0-preview-0007, so there might still be issues with using them together.

@flcdrg
Copy link
Author

flcdrg commented Jul 5, 2019

I wonder if something like ilmerge could be used to inline the LibGit2Sharp assembly for both projects?
There's still the matter of LibGit2Sharp.NativeBinaries though, so maybe not. It's a pity Cake addins aren't isolated a bit more from each other.

@devlead
Copy link
Member

devlead commented Jul 6, 2019

At the moment they can't be more isolated from each other, .NET Core 3 will likely introduce a component model that'll enable better isolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants