fix: disable dummy codegen of rncore #488
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Without
react.jsRootDir
, react-native-gradle-plugin would generaterncore
related code inside library'sbuildDir
whennewArchEnabled
is true. And then duplicate class definition insideReactAndroid
like lottie-react-native/lottie-react-native#1053This impacts library's compatiblitiy with 0.68/0.69/0.70 because of direct dependent on source code of
ReactAndroid
Reproduce
my-lib
legacy module and initialize dependencynewArchEnabled=true
in example/andoridTest plan