-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use prepack instead of prepare #497
Conversation
prepare is used because it runs when people install the package from git. yarn 3 not running it on install is not important since it's not necessary anyway. |
Could you elaborate? I am running yarn v1 and |
Why is it necessary to compile files during install? Yarn 3 or otherwise. Compiled files are for consumers of the npm package and they only need to be compiled during publish step or when installing from Git/local directory. What problem exactly are you trying to solve? |
I'm pulling the package from Github (no npm package yet) and using yarn v1 prepare/prepack is not running. Only working setup is with prepack and yarn v4 so far. Also tried |
https://callstack.github.io/react-native-builder-bob/build#manual-configuration
You want Either way both If you only use Yarn then you can make the change in your project but it doesn't make sense as a default as npm is more widely used. |
I also tested a bit more and when installing from git:
So Yarn 4's behavior makes no sense and if the package is for general consumption, |
Very much appreciated, will try again with |
Summary
Since Yarn v2 and upwards doesn't support
prepare
script anymore I believeprepack
should be used in the template to runbob build
on install.This comment says this should already be set but it wasn't in my case.