Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-github repo support #3

Open
roovo opened this issue Dec 28, 2013 · 1 comment
Open

non-github repo support #3

roovo opened this issue Dec 28, 2013 · 1 comment

Comments

@roovo
Copy link

roovo commented Dec 28, 2013

Loving dockerize - and have been tinkering to see how it could work at work where, unfortunately, we have to use an internal gitlab instance rather than the glorious github.

Where I've got to is to replace the github sub-command with a git one which takes a full git url rather than "just the end bit". As well as supporting our internal gitlab and the existing github it allows images to be built from e.g. the local filesystem or git repos in a simple ssh account.

Downsides I can think of for this are that it means having to enter less convenient references for repos, and it would be a breaking change. I guess it could be possible to support both subcommands, but that just feels like it would be messy for maintenance. Hence me firing this off before proposing an actual pull request - I'd be really interested in your thoughts.

I have forked a version (https://github.com/roovo/dockerize) with this in place if you want to have a look/play and see what you think. I should just say that I also made specifying the branch a command line option as part of this, as the branch name does not form part of a git url (hence it felt wrong to add a :branch on the end).

Very interested in further discussions on this and potentially more than happy to prepare a pull request when/if a workable/agreeable solution is found.

Cheers

Roovo

@gerhard
Copy link
Contributor

gerhard commented Feb 6, 2014

Excellent, so pleased that you've found it useful! I'm happy for you to take it over, I'll be focusing on Docker & Ansible integration. I find that the combo allows me to manage the whole infrastructure end-to-end, it's brilliantly simple (and yet so powerful). If you're following the Docker news, you'll hear when the first blog post will be published. As for the slides, they're available even if I didn't make them public yet. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants