Skip to content
This repository has been archived by the owner on Mar 29, 2019. It is now read-only.

Code inconsistency: getOne() is moved outside, but create() is part of export #114

Open
laszlolm opened this issue Feb 25, 2019 · 1 comment
Open

Code inconsistency: getOne() is moved outside, but create() is part of export #114

laszlolm opened this issue Feb 25, 2019 · 1 comment

Comments

@laszlolm
Copy link
Contributor

https://github.com/caminerinc/treelab-api/blob/4c7c02ee7362fcea38b49d8c739ae3cb51ed1fb9/app/controllers/bases.js#L7

Moving create() out too is recommended
@laszlolm
Copy link
Contributor Author

This should be applied to other controllers too. Some also have methods that could be merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laszlolm