forked from OCA/stock-logistics-warehouse
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_packaging_calculator: Migration to 18.0 #4
Closed
thienvh332
wants to merge
44
commits into
camptocamp:18.0-dev
from
thienvh332:18.0-mig-stock_packaging_calculator
Closed
[18.0][MIG] stock_packaging_calculator: Migration to 18.0 #4
thienvh332
wants to merge
44
commits into
camptocamp:18.0-dev
from
thienvh332:18.0-mig-stock_packaging_calculator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ocabot migration stock_packaging_calculator |
simahawk
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Customizing the minimal unit was not needed at all. This way we always assume the precision is the on of the UoM.
Allows to ship more information with each element in the list.
Optionally include contained packaging qty.
Allows to reuse the mapping every time is needed.
…g calculator return
Make sure unit is always the last element in the list.
Use _packaging_values_handler ctx key to pass your own handler for specific on demand overrides.
Retrieve quickly packagin bty qty as a string.
This mixin can be used to provide qty by packaging features to any model.
Otherwise translations won't be taken into account.
This way no matter who's changing the behavior of the name getter we'll get the right name.
thienvh332
force-pushed
the
18.0-mig-stock_packaging_calculator
branch
from
October 10, 2024 03:35
3863af0
to
8ff7ea8
Compare
/ocabot merge nobump |
@thienvh332 I thought I was already on OCA 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported PRs