Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_packaging_calculator: Migration to 18.0 #4

Conversation

@simahawk
Copy link
Member

simahawk commented Oct 9, 2024

/ocabot migration stock_packaging_calculator

Copy link
Member

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

simahawk and others added 27 commits October 10, 2024 10:34
Customizing the minimal unit was not needed at all.
This way we always assume the precision is the on of the UoM.
Allows to ship more information with each element in the list.
Optionally include contained packaging qty.
Allows to reuse the mapping every time is needed.
Make sure unit is always the last element in the list.
Use _packaging_values_handler ctx key to pass your own handler
for specific on demand overrides.
Retrieve quickly packagin bty qty as a string.
This mixin can be used to provide qty by packaging features
to any model.
Otherwise translations won't be taken into account.
@thienvh332 thienvh332 closed this Oct 10, 2024
@thienvh332 thienvh332 force-pushed the 18.0-mig-stock_packaging_calculator branch from 3863af0 to 8ff7ea8 Compare October 10, 2024 03:35
@simahawk
Copy link
Member

/ocabot merge nobump

@thienvh332
Copy link
Author

Hi @simahawk ,
I'm sorry but I've closed this and created a new PR to merge into the OCA side. Could you come over there? (Link here)

@simahawk
Copy link
Member

@thienvh332 I thought I was already on OCA 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.