Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHIFT+TAB through main navigation doesn't hide the previous menu. #31

Open
LaserLag opened this issue Aug 13, 2020 · 11 comments
Open

SHIFT+TAB through main navigation doesn't hide the previous menu. #31

LaserLag opened this issue Aug 13, 2020 · 11 comments

Comments

@LaserLag
Copy link

Navigating backwards through main navigation with SHIFT+TAB doesn't hide the previous menu. It ends up looking like this:

shifttab

Navigating forward through the menus with TAB works fine.

@josephfusco
Copy link
Contributor

Hey @LaserLag thanks for the feedback!

I haven't been able to reproduce this. Is this still an issue for you? If so can you please provide a link to the site you are experiencing this on? Thank you!

@ramseyba
Copy link

Hi Joseph,

This issue is still present.

Could you take another look? If you need a link, can I send it privately?

Thanks!

Divi Accessibility - Version 2.0.5
WordPress - Version: 5.8
Divi - Version: 4.9.10

Divi Accessibility - keyboard back tab menu overlap

@stewartsavage
Copy link

I am having the same issue. Haven's seen this behavior before. This is a multi-site configuration using a theme builder navigation menu. It is also happening on other standard WordPress sites with standard header navigation that I manage.

In development. Only plugin active is Divi Accessibility. WordPress 5.8.1, Divi 4.11.3.

URL is https://www.abatonweb.com

Also can be seen on https://usbhof.org - Standard WordPress site and navigation menu.

Happens in Chrome and MS Edge browsers

Screenshot 2021-10-19 135951

@joelhsmith
Copy link

We have the same issue when navigating backwards with Shift+Tab

@MomokoSanchez
Copy link

MomokoSanchez commented Nov 27, 2022

Having the same issue. Here's my little emergency fix, if anyone needs it in the meantime (it's not great, but it work):

document.addEventListener("keyup", detectTabKey);
            function detectTabKey(e) {
                if (e.keyCode == 9) {
                    activeElem = document.activeElement;
                    activeElem.parentElement.nextElementSibling && activeElem.parentElement.nextElementSibling.classList.remove("et-hover")
                }
            }

@stewartsavage
Copy link

@MomokoSanchez @joelhsmith @ramseyba @LaserLag

Found a fix for this.

BACKUP FILE BEFORE EDITING

Edit

dropdown_keyboard_navigation.min.js

found in /wp-content/plugins/divi-accessibility-master/public/partials/js

Remove

.is(":last-child")

Save

The menu will open and then close as you navigate with SHIFT+TAB

@billigan
Copy link

billigan commented Apr 27, 2023

@stewartsavage this works for the shift tabbing closing the submenus but also stops the tabbing down through the submenu links.

@stewartsavage
Copy link

stewartsavage commented Apr 27, 2023 via email

@billigan
Copy link

billigan commented Apr 27, 2023

That is what I found also. What I meant was removing that piece of the code stopped the tab down into the submenus. So I could only tab across the main menu links. The submenu dropdown would open but hitting tab just went to the next top level menu link rather than going down the submenu links.

I have a function that I was able to use in the child theme functions.php file but it is not formatting it here correctly when I try to paste it in.
I'll attach it if anyone is interested.
shift tab fix divi.txt

@stewartsavage
Copy link

stewartsavage commented Apr 28, 2023 via email

@billigan
Copy link

You are very welcome.

I just tested the search opening and it does close with shift + tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants