Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single Quotes are not converted to Double Quotes #275

Closed
P3A1 opened this issue May 10, 2023 · 0 comments · Fixed by #274
Closed

Single Quotes are not converted to Double Quotes #275

P3A1 opened this issue May 10, 2023 · 0 comments · Fixed by #274
Labels
bug Something isn't working triage

Comments

@P3A1
Copy link

P3A1 commented May 10, 2023

Describe the bug

In my process (7.19) I use the following expression as a condition on a sequence

${kanal == 'CI' || kanal == 'PCS'}

This is converted into

=kanal = 'CI' or kanal = 'PCS'

which is wrong, because FEEL doesn't support single quotes.

It should be

=kanal = "CI" or kanal = "PCS"

My local bugfix worked fine for me.
I added this generous mapping rule to the ExpressionTransformer.java

.replaceAll("'", """);

and this to the ExpressionTransformerTest.java

expression("${x == '1'}").isMappedTo("=x = "1""),

Steps to reproduce

see above

Expected Behaviour

see above

Library version

x

Camunda version

y

Camunda Distribution

Tomcat

Other Camunda distribution

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant