Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize: Rawdata report settings tab is not scrollable #4940

Open
1 task
venetrius opened this issue Feb 13, 2025 · 0 comments
Open
1 task

Optimize: Rawdata report settings tab is not scrollable #4940

venetrius opened this issue Feb 13, 2025 · 0 comments
Labels
group:support All requests that are linked to a customer request. DRI: Tassilo potential:optimize 3.15.3 scope:optimize Changes to Optimize. type:bug Issues that describe a user-facing bug in the project.

Comments

@venetrius
Copy link
Member

venetrius commented Feb 13, 2025

Environment (Required on creation)

Optimize 3.15

Description (Required on creation; please attach any relevant screenshots, stacktraces, log files, etc. to the ticket)

Steps to reproduce (Required on creation)

  • Create a Process Report of type raw data (from a process definition that has many variables)
screenshot

Image

  • activate “update preview automatically"
  • next to visualization press the “gear”,
  • adjust the window size in a way that settings popup fits in the view perfectly.
screenshot Image
  • open the VARIABLES Tab, there is no scrollbar
screenshot Image

Observed Behavior (Required on creation)

The settings tab does not fit in the screen, but no scroll bar is present
Image

Expected behavior (Required on creation)

If the settings popover does not fit in screen, then the scroll bar is always present

Root Cause (Required on prioritization)

The tab is rendered by the Popover component.
calculateDialogStyle is the function that sets scrollable.
calculateDialogStyle is only called on handleResize. This happens if the size of the browser window is changed. This is not triggered when the Popover component size has changed

Solution Ideas

Resize event can be triggered via window.dispatchEvent(new Event('resize')); from Configuration which renderes Popover

Hints

In Popover calculateDialogStyle it need to be checked that all size are updated accordingly to the current DOM.

Conditionals that sets scrollable

    if (bottomSpace < contentHeightWithPadding && topSpace > bottomSpace) {
      const scrollable = contentHeightWithPadding > topSpace;
      setScrollable(scrollable);
      dialogStyles.height = (scrollable ? topSpace : contentHeightWithPadding) + 'px';
      newAlignment = newAlignment.replace('bottom', 'top') as PopoverAlignment;
    }

Links

SUPPORT-25801

Breakdown

Pull Requests

Preview Give feedback

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@venetrius venetrius added group:support All requests that are linked to a customer request. DRI: Tassilo scope:optimize Changes to Optimize. type:bug Issues that describe a user-facing bug in the project. labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group:support All requests that are linked to a customer request. DRI: Tassilo potential:optimize 3.15.3 scope:optimize Changes to Optimize. type:bug Issues that describe a user-facing bug in the project.
Projects
None yet
Development

No branches or pull requests

2 participants