Skip to content

Commit

Permalink
fix(zeebe-grpc-ingress): class check for openshift was not checked (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
leiicamundi authored Dec 13, 2024
1 parent 9318266 commit 873dbd0
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 27 deletions.
3 changes: 1 addition & 2 deletions charts/camunda-platform-8.6/templates/camunda/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,7 @@ spec:
{{- end }}
{{- if .Values.global.ingress.tls.enabled }}
{{- if and (not .Values.global.ingress.tls.secretName) (contains "openshift-" (default "" .Values.global.ingress.className)) }}
# The tls block is not applied because .Values.global.ingress.tls.secretName is empty
# and .Values.global.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ spec:
number: 8080
{{- if .Values.connectors.ingress.tls.enabled }}
{{- if and (not .Values.connectors.ingress.tls.secretName) (contains "openshift-" (default "" .Values.connectors.ingress.className)) }}
# The tls block is not applied because .Values.connectors.ingress.tls.secretName is empty
# and .Values.connectors.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
3 changes: 1 addition & 2 deletions charts/camunda-platform-8.6/templates/console/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ spec:
number: 80
{{- if .Values.console.ingress.tls.enabled }}
{{- if and (not .Values.console.ingress.tls.secretName) (contains "openshift-" (default "" .Values.console.ingress.className)) }}
# The tls block is not applied because .Values.console.ingress.tls.secretName is empty
# and .Values.console.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ spec:
number: 80
{{- if .Values.executionIdentity.ingress.tls.enabled }}
{{- if and (not .Values.executionIdentity.ingress.tls.secretName) (contains "openshift-" (default "" .Values.executionIdentity.ingress.className)) }}
# The tls block is not applied because .Values.executionIdentity.ingress.tls.secretName is empty
# and .Values.executionIdentity.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
3 changes: 1 addition & 2 deletions charts/camunda-platform-8.6/templates/identity/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ spec:
number: 80
{{- if .Values.identity.ingress.tls.enabled }}
{{- if and (not .Values.identity.ingress.tls.secretName) (contains "openshift-" (default "" .Values.identity.ingress.className)) }}
# The tls block is not applied because .Values.identity.ingress.tls.secretName is empty
# and .Values.identity.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
3 changes: 1 addition & 2 deletions charts/camunda-platform-8.6/templates/operate/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ spec:
number: 80
{{- if .Values.operate.ingress.tls.enabled }}
{{- if and (not .Values.operate.ingress.tls.secretName) (contains "openshift-" (default "" .Values.operate.ingress.className)) }}
# The tls block is not applied because .Values.operate.ingress.tls.secretName is empty
# and .Values.operate.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
3 changes: 1 addition & 2 deletions charts/camunda-platform-8.6/templates/optimize/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ spec:
number: 80
{{- if .Values.optimize.ingress.tls.enabled }}
{{- if and (not .Values.optimize.ingress.tls.secretName) (contains "openshift-" (default "" .Values.optimize.ingress.className)) }}
# The tls block is not applied because .Values.optimize.ingress.tls.secretName is empty
# and .Values.optimize.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
3 changes: 1 addition & 2 deletions charts/camunda-platform-8.6/templates/tasklist/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ spec:
number: 80
{{- if .Values.tasklist.ingress.tls.enabled }}
{{- if and (not .Values.tasklist.ingress.tls.secretName) (contains "openshift-" (default "" .Values.tasklist.ingress.className)) }}
# The tls block is not applied because .Values.tasklist.ingress.tls.secretName is empty
# and .Values.tasklist.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ spec:
(not .Values.webModeler.ingress.websockets.tls.secretName)
(contains "openshift-" (default "" .Values.webModeler.ingress.className))
}}
# The tls block is not applied because both .Values.webModeler.ingress.webapp.tls.secretName and .Values.webModeler.ingress.websockets.tls.secretName are empty
# and .Values.webModeler.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ spec:
(not .Values.zeebeGateway.ingress.grpc.tls.secretName)
(contains "openshift-" (default "" .Values.zeebeGateway.ingress.grpc.className))
}}
# The tls block is not applied because .Values.zeebeGateway.ingress.grpc.tls.secretName is empty
# and .Values.zeebeGateway.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ spec:
(not .Values.zeebeGateway.ingress.rest.tls.secretName)
(contains "openshift-" (default "" .Values.zeebeGateway.ingress.rest.className))
}}
# The tls block is not applied because .Values.zeebeGateway.ingress.rest.tls.secretName is empty
# and .Values.zeebeGateway.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,9 @@ spec:
{{- if .Values.core.ingress.grpc.tls.enabled }}
{{- if and
(not .Values.core.ingress.grpc.tls.secretName)
(contains "openshift-" (default "" .Values.core.ingress.className))
(contains "openshift-" (default "" .Values.core.ingress.grpc.className))
}}
# The tls block is not applied because .Values.core.ingress.grpc.tls.secretName is empty
# and .Values.core.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,7 @@ spec:
(not .Values.global.ingress.tls.secretName)
(contains "openshift-" (default "" .Values.global.ingress.className))
}}
# The tls block is not applied because .Values.global.ingress.tls.secretName is empty
# and .Values.global.ingress.className contains "openshift-".
# The tls block is not applied because secretName is empty and className contains "openshift-".
# This is necessary to use the certificate managed by the OpenShift Ingress operator,
# which will automatically convert this Ingress into a Route (https://docs.redhat.com/en/documentation/openshift_container_platform/4.17/html/security_and_compliance/configuring-certificates#replacing-default-ingress_replacing-default-ingress).
{{- else }}
Expand Down

0 comments on commit 873dbd0

Please sign in to comment.