Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize log out button is visible in the UI #2572

Closed
RomanJRW opened this issue Nov 15, 2024 · 7 comments
Closed

Optimize log out button is visible in the UI #2572

RomanJRW opened this issue Nov 15, 2024 · 7 comments
Assignees
Labels
kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between platform/aws Issues related to AWS platform/gcp Issues related to GCP size/xs Relative effort/time: Extra Small support Marks an issue as related to a customer support request (don't edit the lable) workflow/no-action No action is needed or will be done for this issue

Comments

@RomanJRW
Copy link
Contributor

RomanJRW commented Nov 15, 2024

Describe the issue:

Optimize SM does not support logging out with Identity. However, the button is visible in the UI, leading to confusing behaviour for the customer

Hint: Optimize has the following config option which allows the log out button to be hidden:

ui:
  # If you have SSO enabled, you can set the property below to hide the logout option if it is not needed
  logoutHidden: ${CAMUNDA_OPTIMIZE_UI_LOGOUT_HIDDEN:false}

Origin: https://jira.camunda.com/browse/SUPPORT-22732

Actual behavior:

The log out button is visible but does not work properly

Expected behavior:

The log out button should be hidden

How to reproduce:

Logs:

Environment:

Please note: Without the following info, it's hard to resolve the issue and probably it will be closed.

  • Platform:
  • Helm CLI version:
  • Chart version:
  • Values file:
@RomanJRW RomanJRW added the kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between label Nov 15, 2024
@github-actions github-actions bot added platform/aws Issues related to AWS platform/gcp Issues related to GCP labels Nov 15, 2024
@RomanJRW RomanJRW changed the title [ISSUE] <issue title> Optimize log out button is visible in the UI Nov 15, 2024
@RomanJRW RomanJRW added the support Marks an issue as related to a customer support request (don't edit the lable) label Nov 15, 2024
@aabouzaid
Copy link
Member

Looking at this issue, and found no history for it, it could have been removed by mistake.

I will add it to the 8.7 release cycle 👍

@aabouzaid aabouzaid added this to the 8.7 Release Cycle milestone Nov 15, 2024
@aabouzaid aabouzaid added size/xs Relative effort/time: Extra Small cycle/pre-release Tasks will be done in pre-release cycle labels Nov 15, 2024
@alexcorremans
Copy link

Since this is a bug, is there a reason why we're not including it in an earlier patch release?

@aabouzaid
Copy link
Member

aabouzaid commented Nov 15, 2024

Since this is a bug, is there a reason why we're not including it in an earlier patch release?

@alexcorremans, we have no capacity for it, and it has too low impact.

Also, I'm unsure if it's a real issue, as I see the logout button in the latest stable version, 8.6, and the latest alpha version, 8.7 alpha1.

I still need to check 8.5, but maybe the user just doesn't see it.

@aabouzaid
Copy link
Member

@RomanJRW, I confirm the logout button is visible in the UI and works as expected back to 8.5.8 (it shows on the user icon).

Feel free to close this issue if that's the case.

optimize-8 5-8-logout

@alexcorremans
Copy link

@aabouzaid isn't the problem here that we are displaying the logout button, since it doesn't actually work?

@aabouzaid
Copy link
Member

@alexcorremans I can confirm it works for me on Camunda 8.5.8 and Firefox 125.0.2.
We need some steps to reproduce it.

@aabouzaid
Copy link
Member

After discussing with @RomanJRW, I'm closing this issue for now as it looks false positive.
We could open it again when we have more evidence about it.

@aabouzaid aabouzaid self-assigned this Dec 2, 2024
@aabouzaid aabouzaid added workflow/no-action No action is needed or will be done for this issue and removed cycle/pre-release Tasks will be done in pre-release cycle labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/issue Unidentified issue, it could be a bug, misconfig, or anything in between platform/aws Issues related to AWS platform/gcp Issues related to GCP size/xs Relative effort/time: Extra Small support Marks an issue as related to a customer support request (don't edit the lable) workflow/no-action No action is needed or will be done for this issue
Projects
None yet
Development

No branches or pull requests

3 participants