Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add default webModler url when ingress is disabled #2566

Merged
merged 6 commits into from
Dec 3, 2024
Merged

fix: add default webModler url when ingress is disabled #2566

merged 6 commits into from
Dec 3, 2024

Conversation

drodriguez-305
Copy link
Contributor

@drodriguez-305 drodriguez-305 commented Nov 14, 2024 •
edited
Loading

Which problem does the PR fix?

Console configmap will not read the url if not set in the helpers when there is no ingress. This quickfix will resolve the default static localhost for webModeler.

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@drodriguez-305 drodriguez-305 added kind/fix version/8.6 Camunda applications/cycle version labels Nov 14, 2024
@drodriguez-305 drodriguez-305 self-assigned this Nov 14, 2024
@drodriguez-305 drodriguez-305 linked an issue Nov 14, 2024 that may be closed by this pull request
[ISSUE] webModeler url not applied correctly in console configmap when ingress is disabled #2565
Closed
jessesimpson36
jessesimpson36 reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@jessesimpson36 jessesimpson36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

charts/camunda-platform-8.6/templates/camunda/_helpers.tpl Outdated Show resolved Hide resolved
charts/camunda-platform-8.6/templates/camunda/_helpers.tpl Show resolved Hide resolved
@jessesimpson36
Copy link
Contributor

failing tests appear to be irrelevant

@drodriguez-305 drodriguez-305 merged commit 678da17 into main Dec 3, 2024
21 of 25 checks passed
@drodriguez-305 drodriguez-305 deleted the fix-webModelerWebApp-url-helpers branch December 3, 2024 14:35
@distro-ci distro-ci bot mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesimpson36 jessesimpson36 jessesimpson36 approved these changes

Assignees

@drodriguez-305 drodriguez-305

Labels
kind/fix version/8.6 Camunda applications/cycle version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] webModeler url not applied correctly in console configmap when ingress is disabled
2 participants
@drodriguez-305 @jessesimpson36