Deprecated Java-API in Bootstrapping Documentation

[nils-christian]

Hi,

I noticed the usage of a deprecated Java API in the documentation.

Which documentation is missing/incorrect?

In the bootstrapping documentation you show how to initialize the engine.

final FeelEngine engine = new FeelEngine.Builder()
            .valueMapper(SpiServiceLoader.loadValueMapper())
            .functionProvider(SpiServiceLoader.loadFunctionProvider())
            .build();

The Builder class is deprecated. Instead something like the following has to be used

final FeelEngine engine = new FeelEngine( SpiServiceLoader.loadFunctionProvider( ), SpiServiceLoader.loadValueMapper( ), new FeelEngine.Configuration( false ), null );

or

final FeelEngine engine = new FeelEngine( SpiServiceLoader.loadFunctionProvider( ), SpiServiceLoader.loadValueMapper( ), FeelEngine$.MODULE$.defaultConfiguration( ), FeelEngine$.MODULE$.defaultClock( ) );

The second code is a very weird notation for a Java developer though.

Link to the documentation:

• https://camunda.github.io/feel-scala/docs/developer-guide/bootstrapping

Best regards

Nils

[nils-christian]

Sorry for the additional comment, but I just noticed that a lot of methods are deprecated in the feel engine. It seems that instead the FeelEngineApi should be used. Please correct this in the documentation.

[saig0]

@nils-christian you're right. The developer guide is outdated. 🙈

For Java, you should use:

FeelEngineApi feelEngine = FeelEngineBuilder.create().build();

// or especially for Java code:
FeelEngineApi feelEngine = FeelEngineBuilder.forJava().build();