Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transformers to use the Nov 2024 ballot releases #415

Closed
korikuzma opened this issue Dec 19, 2024 · 2 comments · Fixed by #420
Closed

Update transformers to use the Nov 2024 ballot releases #415

korikuzma opened this issue Dec 19, 2024 · 2 comments · Fixed by #420
Assignees
@korikuzma
Labels
enhancement New feature or request priority:high High priority

Comments

@korikuzma
Copy link
Member

The following tags were created:

We should update the CIViC and MOA Transformer classes to use these updated models from corresponding ga4gh packages.
@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Dec 19, 2024
@korikuzma korikuzma self-assigned this Dec 19, 2024
@korikuzma
Copy link
Member Author

Not only does this include updating ga4gh package, but also all of our normalizers.

@korikuzma korikuzma mentioned this issue Jan 21, 2025
Merged
@korikuzma korikuzma linked a pull request Jan 27, 2025 that will close this issue
feat!: update models to ga4gh gks nov 2024 ballot releases #420
Merged
korikuzma added a commit that referenced this issue Feb 14, 2025
@korikuzma
feat!: update models to ga4gh gks nov 2024 ballot releases (#420)
c36a564 
close #415

Changes:
* Update vicc normalizers and ga4gh gks versions to point to nov 2024
ballot releases
* This also updates transformers to use correct representations with
these new models
* Therapeutic Procedure / Agent --> Therapy rename to align with GKS

Comments:
* In a previous version, we created `Proposition` nodes in the database.
Since we need to get something out ASAP, I did not create these. If
needed in the future, we can create a new issue.
* CIViC was generated used the cache
[here](https://github.com/cancervariants/metakb/blob/issue-415/tests/data/harvesters/civic/civicpy_cache_20240612.pkl)
@github-actions GitHub Actions
Copy link

Closed by #420.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: update models to ga4gh gks nov 2024 ballot releases cancervariants/metakb
1 participant
@korikuzma