feat!: change strength representation #424
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiestahl
reviewed
Jan 27, 2025
| mappings = strength.get("mappings", []) | ||
| if mappings: | ||
| statement["strength_mappings"] = json.dumps(mappings) | ||
| strength_keys.append("mappings:$strength_mappings") |
There was a problem hiding this comment.
this line is confusing me. Is this just acting as a placeholder?
There was a problem hiding this comment.
This allows us to create both the strength node and statement node. Line 494 allows the transaction to access the strength values. The following lines includes the key/value pairs needed for line 499
mcannon068nw
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@katiestahl @mcannon068nw keeping as draft until #420 is merged, but this is ready for review.
close #419
code-->primaryCodesystemand addmappings