Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface test for smtp v0 failed. #189

Open
benhoyt opened this issue Nov 6, 2024 · 9 comments · Fixed by canonical/smtp-integrator-operator#73
Open

Interface test for smtp v0 failed. #189

benhoyt opened this issue Nov 6, 2024 · 9 comments · Fixed by canonical/smtp-integrator-operator#73

Comments

@benhoyt
Copy link
Collaborator

benhoyt commented Nov 6, 2024

Tests for interface smtp v0 failed.

Provider

  • smtp-integrator: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/11713777734 for more detail.

@shipperizer, @BarcoMasile, @nsklikas, @wood-push-melon, @natalian98, @massigori, @canonical-iam, @pik4ez-canonical

@natalian98
Copy link
Contributor

@arturo-seijas @weiiwang01

@weiiwang01
Copy link
Contributor

It seems the error is caused by the saml-integrator charm, which uses the new union type syntax for Python 3.10, while the test is running on 3.8. Do we need to update the saml-integrator to be compatible with Python 3.8 or upgrade the interface test to run on Python 3.10?

https://github.com/canonical/charm-relation-interfaces/actions/runs/11713777734/job/32627184551#step:5:911

@benhoyt
Copy link
Collaborator Author

benhoyt commented Nov 11, 2024

Tests for interface smtp v0 failed.

Provider

  • smtp-integrator: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/11769735758 for more detail.

@shipperizer, @BarcoMasile, @nsklikas, @wood-push-melon, @natalian98, @massigori, @canonical-iam, @pik4ez-canonical

@weiiwang01
Copy link
Contributor

@benhoyt @natalian98 I've added backward compatibility to the smtp-integrator charm for Python 3.8. Let me know if you encounter any other issues.

@prints-charming-bot
Copy link
Collaborator

@prints-charming-bot
Copy link
Collaborator

@prints-charming-bot
Copy link
Collaborator

@prints-charming-bot
Copy link
Collaborator

@prints-charming-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants