Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface test for tempo_cluster v1 failed. #210

Open
prints-charming-bot opened this issue Dec 9, 2024 · 6 comments · May be fixed by #214
Open

Interface test for tempo_cluster v1 failed. #210

prints-charming-bot opened this issue Dec 9, 2024 · 6 comments · May be fixed by #214

Comments

@prints-charming-bot
Copy link
Collaborator

Tests for interface tempo_cluster v1 failed.

Requirer

  • tempo-worker-k8s: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/12226558233 for more detail.

@mmkay, @Abuelodelanada, @simskij, @dstathis, @PietroPasotti, @michaeldmitry, @lucabello, @ca-scribner, @IbraAoad, @sed-i, @MichaelThamm

@mmkay
Copy link
Contributor

mmkay commented Dec 10, 2024

Cause:

ERROR    pytest_interface_tester:plugin.py:343 Interface tester plugin failed with Relation.__init__() got an unexpected keyword argument 'charm_tracing_receivers'
Traceback (most recent call last):
  File "/tmp/charm-relation-interfaces-tests/tempo-worker-k8s/.interface-venv/lib/python3.10/site-packages/interface_tester/plugin.py", line 341, in run
    test_fn()
  File "/tmp/tmpz8x4d10l/charm-relation-interfaces/interfaces/tempo_cluster/v1/interface_tests/test_requirer.py", line 14, in test_data_on_created
TypeError: Relation.__init__() got an unexpected keyword argument 'charm_tracing_receivers'

Looks like we added new fields to the relation in https://github.com/canonical/charm-relation-interfaces/blob/main/interfaces/tempo_cluster/v1/interface_tests/test_requirer.py#L19 but we should put them in remote_app_data on the same level as worker_config.

@michaeldmitry michaeldmitry linked a pull request Dec 10, 2024 that will close this issue
@prints-charming-bot
Copy link
Collaborator Author

Tests for interface tempo_cluster v1 failed.

Requirer

  • tempo-worker-k8s: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/12343535560 for more detail.

@mmkay, @Abuelodelanada, @simskij, @dstathis, @PietroPasotti, @michaeldmitry, @lucabello, @ca-scribner, @IbraAoad, @sed-i, @MichaelThamm

@prints-charming-bot
Copy link
Collaborator Author

Tests for interface tempo_cluster v1 failed.

Requirer

  • tempo-worker-k8s: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/12458885544 for more detail.

@mmkay, @Abuelodelanada, @simskij, @dstathis, @PietroPasotti, @michaeldmitry, @lucabello, @ca-scribner, @IbraAoad, @sed-i, @MichaelThamm

@prints-charming-bot
Copy link
Collaborator Author

Tests for interface tempo_cluster v1 failed.

Requirer

  • tempo-worker-k8s: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/12539863453 for more detail.

@mmkay, @Abuelodelanada, @simskij, @dstathis, @PietroPasotti, @michaeldmitry, @lucabello, @ca-scribner, @IbraAoad, @sed-i, @MichaelThamm

@prints-charming-bot
Copy link
Collaborator Author

Tests for interface tempo_cluster v1 failed.

Requirer

  • tempo-worker-k8s: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/12624185433 for more detail.

@mmkay, @Abuelodelanada, @simskij, @dstathis, @PietroPasotti, @michaeldmitry, @lucabello, @ca-scribner, @IbraAoad, @sed-i, @MichaelThamm

@prints-charming-bot
Copy link
Collaborator Author

Tests for interface tempo_cluster v1 failed.

Requirer

  • tempo-worker-k8s: False

See the workflow https://github.com/canonical/charm-relation-interfaces/actions/runs/12738363896 for more detail.

@mmkay, @Abuelodelanada, @simskij, @dstathis, @PietroPasotti, @michaeldmitry, @lucabello, @ca-scribner, @IbraAoad, @sed-i, @MichaelThamm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants