Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set activations keys for byobu and set_passwords #5890

Closed
wants to merge 1 commit into from

Conversation

holmanb
Copy link
Member

@holmanb holmanb commented Nov 20, 2024

Proposed Commit Message

chore: set activations keys for byobu and set_passwords

Additional Context

These two modules are not enabled by default, so set activation keys for them.

Note to reviewer: please double check cc_set_passwords.py.

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason these two weren't taken care of in the initial change is these both allow for arguments from the base configuration. While I don't really care to support that use case anymore, changing that would be a breaking change we would want to patch out. If we were to stop supporting arguments in these two modules, I think we should stop supporting them everywhere and change the API accordingly.

...but that's a bigger effort.

@TheRealFalcon TheRealFalcon self-assigned this Nov 26, 2024
@holmanb
Copy link
Member Author

holmanb commented Nov 27, 2024

I think the reason these two weren't taken care of in the initial change is these both allow for arguments from the base configuration.

True

While I don't really care to support that use case anymore, changing that would be a breaking change we would want to patch out. If we were to stop supporting arguments in these two modules, I think we should stop supporting them everywhere and change the API accordingly.

...but that's a bigger effort.

True. I'll close this for now.

@holmanb holmanb closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants