-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jlink support for Java plugin #891
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3627.
|
The jlink part of this is fine, but I'm not sure about this |
I think we should use the plugin to run the wrappers. There is a use-case for gradle wrapper (as we have discussed) and for a maven wrapper (to a lesser extent). So by default we should use java plugin to execute The gradle plugin should use gradle provided by the dependency, rather than call the wrapper. |
Today we (myself, @vpa1977 and @mr-cal) met and talked about this topic. We ended up agreeing that a general "jlink" plugin, which would generate a Java runtime for multiple Java parts (leveraging the existing From the other options, using an Extension wouldn't be possible because the jlink call needs parameters, and a build-attribute is also not possible not only because of the parameters (which build-attributes currently do not support), but also because the intention is to process the jars from multiple parts at the same time, to generate a single runtime. |
Introduce jlink plugin to create Java runtime for the application. canonical#891
Introduce jlink plugin to create Java runtime for the application. canonical#891
What needs to get done
Java plugin should set JAVA_HOME #891 and provide a way to generate runtime for the Java application.
This can be done by running
jlink
and passing a list of jar files. Java plugin by default copies files to$CRAFT_PART_INSTALL/jars
and java plugin will pick up jars from this location in post build commands and generate the runtime for those jars. User should be able to specify the version of the Java to use and list of jar files and directories if the default value is not acceptable. User should be able to specify if he wants to run a jlink step.Java should be available as a plugin so that build without applying derivative plugins is supported.
Why it needs to get done
To have a lean runtime for java applications
The text was updated successfully, but these errors were encountered: