Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step execution environment documentation is incomplete and out of date #948

Open
lengau opened this issue Dec 19, 2024 · 1 comment · May be fixed by #949
Open

Step execution environment documentation is incomplete and out of date #948

lengau opened this issue Dec 19, 2024 · 1 comment · May be fixed by #949
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Triaged

Comments

@lengau
Copy link
Contributor

lengau commented Dec 19, 2024

What needs to get done

The Step execution environment documentation is incomplete, missing at least the following:

  • CRAFT_ARCH_BUILD_ON
  • CRAFT_ARCH_BUILD_FOR
  • CRAFT_ARCH_TRIPLET_BUILD_ON
  • CRAFT_ARCH_TRIPLET_BUILD_FOR
  • CRAFT_STEP_NAME

The first four of those are especially problematic since they replace deprecated keys, and the documentation doesn't note that CRAFT_ARCH_TRIPLET and CRAFT_TARGET_ARCH are deprecated.

It also doesn't include several changes to existing environment variables that we make, including:

  • Prepending a large number of directories to $PATH (roughly equivalent to exporting PATH=$CRAFT_PART_INSTALL/usr/sbin:$CRAFT_PART_INSTALL/usr/bin:$CRAFT_PART_INSTALL/sbin:$CRAFT_PART_INSTALL/bin:$CRAFT_STAGE/usr/sbin:$CRAFT_STAGE/usr/bin:$CRAFT_STAGE/sbin:$CRAFT_STAGE/bin:$PATH)
  • Similar changes to CPPFLAGS, CFLAGS, CXXFLAGS
  • Related changes to LDFLAGS
  • Similar changes to PKG_CONFIG_PATH

Why it needs to get done

The former group can be frustrating for users who don't know what to do about our deprecation notice, and the latter can cause confusion to users if, for example, an unexpected executable gets run.

@lengau lengau added Documentation Improvements or additions to documentation Enhancement New feature or request labels Dec 19, 2024
@lengau lengau added the Triaged label Dec 20, 2024
Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3846.

This message was autogenerated

@lengau lengau linked a pull request Dec 20, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Enhancement New feature or request Triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant