Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPMISensorStateNotOk alert should ignore type="Slot/Connector" #107

Closed
przemeklal opened this issue Nov 16, 2023 · 1 comment · Fixed by #111
Closed

IPMISensorStateNotOk alert should ignore type="Slot/Connector" #107

przemeklal opened this issue Nov 16, 2023 · 1 comment · Fixed by #111
Assignees
@dashmage
Labels
bug Something isn't working
Milestone
23.10.1

Comments

@przemeklal
Copy link
Member

We received a lot of false positive alerts:

ipmi_generic_sensor_value{instance="openstack_da86533f-1112-430b-9bf3-6bad455a2a7a_ceph-osd_ceph-osd/0", job="hardware-observer_0_default", juju_application="ceph-osd", juju_model="openstack", juju_model_uuid="da86533f-1112-430b-9bf3-6bad455a2a7a", juju_unit="ceph-osd/0", name="LOM P1 Link Down", state="Warning", type="Slot/Connector", unit="N/A"

By default, type="Slot/Connector" warnings should be ignored, all disconnected LOM ports will keep generating the alerts otherwise.
@jneo8
Copy link
Contributor

jneo8 commented Nov 16, 2023

We can provide a similar fix like #101 .

dashmage added a commit to dashmage/hardware-observer-operator that referenced this issue Nov 17, 2023
@dashmage
fix(alert): Ignore IPMI slot connector alerts.
27e2f3c 
Fixes: canonical#107
dashmage added a commit to dashmage/hardware-observer-operator that referenced this issue Nov 17, 2023
@dashmage
fix(alert): Ignore IPMI slot connector alerts.
904377a 
Fixes: canonical#107
@dashmage dashmage mentioned this issue Nov 17, 2023
Merged
@dashmage dashmage self-assigned this Nov 17, 2023
agileshaw pushed a commit that referenced this issue Nov 21, 2023
@dashmage
fix(alert): Ignore IPMI slot connector alerts. (#111)
e8a2bcb 
* fix(alert): Ignore IPMI slot connector alerts.

Fixes: #107

* Add input series for slot connector in tests.

Also reduce alert expr by removing duplicate type.

* Add comment to IPMI sensor state alert.
@Pjack Pjack added the bug Something isn't working label Nov 30, 2023
@Pjack Pjack added this to the 23.10.1 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dashmage dashmage

Labels
bug Something isn't working
Projects
None yet
Milestone
23.10.1
Development

Successfully merging a pull request may close this issue.

fix(alert): Ignore IPMI slot connector alerts. dashmage/hardware-observer-operator
4 participants
@Pjack @jneo8 @dashmage @przemeklal