Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources should be installed when it's uploaded #114

Closed
chanchiwai-ray opened this issue Nov 21, 2023 · 2 comments · Fixed by #137
Closed

Resources should be installed when it's uploaded #114

chanchiwai-ray opened this issue Nov 21, 2023 · 2 comments · Fixed by #137
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@chanchiwai-ray
Copy link
Contributor

chanchiwai-ray commented Nov 21, 2023

Currently, resources will only be installed when the charm is first installed. It would be better that the resources can be installed whenever they are uploaded (of course, we should install the resources if they are needed). This could be useful if the operator decided to change the resources, or if there are new hardware added to the servers, and the operator want to also observe that hardware.

@chanchiwai-ray chanchiwai-ray added bug Something isn't working enhancement New feature or request labels Nov 21, 2023
@Pjack Pjack removed the bug Something isn't working label Nov 21, 2023
@Pjack
Copy link

Pjack commented Nov 21, 2023

This issue is used to track the potential problem found in #110 .
If the corresponding resource is not installed during charm deployment (because of network or hardware issue), after the hardware available, there should be a mechanism to trigger the installation of resource and enable the collector.

@Pjack Pjack added this to the 23.10.2 milestone Nov 30, 2023
@jneo8
Copy link
Contributor

jneo8 commented Dec 4, 2023

We decide to use action to recover that and also a retry policy in install hook.

@jneo8 jneo8 self-assigned this Dec 4, 2023
@Pjack Pjack linked a pull request Dec 26, 2023 that will close this issue
@Pjack Pjack closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants