Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .charm artefacts in individual integraton tests #639

Open
DnPlas opened this issue Dec 17, 2024 · 2 comments · Fixed by #640
Open

Use .charm artefacts in individual integraton tests #639

DnPlas opened this issue Dec 17, 2024 · 2 comments · Fixed by #640
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Dec 17, 2024 •
edited
Loading

Context

Based on the changes proposed in #635 and canonical/bundle-kubeflow#1070, and assuming the changes introduced by canonical/charmed-kubeflow-workflows#88, the individual integration tests must:

  • Download the charm artefacts generated by the get_charms_build_with_cache.yaml reusable workflow and use them for deploying them and run tests on top
  • Not build the charms

What needs to get done

  1. Allow the integration job to download the charm artefacts
  2. Remove the build step from every individual integration test
  3. Use the charm artefacts for deploying charms under test

Definition of Done

Individual integration tests use charm artefacts to deploy and test them.
@DnPlas DnPlas added the enhancement New feature or request label Dec 17, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6696.

This message was autogenerated

@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-6697.

This message was autogenerated

DnPlas added a commit that referenced this issue Dec 17, 2024
@DnPlas
ci, tests: pass charm artefacts to deploy and test charms
be89868 
This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).

Fixes: #639
@DnPlas DnPlas mentioned this issue Dec 17, 2024
Merged
DnPlas added a commit that referenced this issue Dec 17, 2024
@DnPlas
ci, tests: pass charm artefacts to deploy and test charms
7e97d95 
This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).

Fixes: #639
DnPlas added a commit that referenced this issue Dec 17, 2024
@DnPlas
ci, tests: pass charm artefacts to deploy and test charms
a425c46 
This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).

Fixes: #639
DnPlas added a commit that referenced this issue Dec 17, 2024
@DnPlas
ci, tests: pass charm artefacts to deploy and test charms
57f219b 
This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).

Fixes: #639
DnPlas added a commit that referenced this issue Jan 9, 2025
@DnPlas
ci, tests: pass charm artefacts to deploy and test charms (#640)
9c543d8 
* ci, tests: pass charm artefacts to deploy and test charms

This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).

Fixes: #639
@DnPlas DnPlas mentioned this issue Jan 9, 2025
Closed
NohaIhab pushed a commit that referenced this issue Jan 24, 2025
@DnPlas @NohaIhab
ci, tests: pass charm artefacts to deploy and test charms (#640)
11af2a7 
* ci, tests: pass charm artefacts to deploy and test charms

This commit enables the "--charm-path" option to pass .charm artefacts
to be deployed and tested at an individual level.
This change enables the option to pass pre-built charms to the tests
to avoid building them on the same test. It also ensures compatibility
with the build_charm.py reusable workflow (from canonical/data-platform-workflows).

Fixes: #639

Use single (cached) build for integration tests & release

Fix hardcoded path for `platforms` syntax

skip: remove duplicated download-charms

remove workflow dispatch from release.yaml not needed

add description for outputs

rename get charm paths job and channel output

skip: rename job in needs

pin quality checks back to main due to merging canonical/charmed-kubeflow-workflows#95

Use stage instead of prime in charmcraft files part (#658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@DnPlas