Skip to content

Commit

Permalink
TO REMOVE
Browse files Browse the repository at this point in the history
Signed-off-by: Gabriel Mougard <[email protected]>
  • Loading branch information
gabrielmougard committed Feb 26, 2025
1 parent 446e6f4 commit 825fef8
Show file tree
Hide file tree
Showing 2 changed files with 188 additions and 188 deletions.
50 changes: 25 additions & 25 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,20 @@ jobs:

# XXX: `make static-analysis` also run shellcheck but this one provides
# useful feedback in the PR through github-code-scanning bot
- id: ShellCheck
name: Differential ShellCheck
uses: redhat-plumbers-in-action/differential-shellcheck@dd551ce780d8af741f8cd8bab6982667b906b457 # v5.5.3
with:
token: ${{ secrets.GITHUB_TOKEN }}
strict-check-on-push: true
if: github.event_name == 'pull_request'

- name: Upload artifact with ShellCheck defects in SARIF format
uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4.6.1
with:
name: Differential ShellCheck SARIF
path: ${{ steps.ShellCheck.outputs.sarif }}
if: github.event_name == 'pull_request'
# - id: ShellCheck
# name: Differential ShellCheck
# uses: redhat-plumbers-in-action/differential-shellcheck@dd551ce780d8af741f8cd8bab6982667b906b457 # v5.5.3
# with:
# token: ${{ secrets.GITHUB_TOKEN }}
# strict-check-on-push: true
# if: github.event_name == 'pull_request'

# - name: Upload artifact with ShellCheck defects in SARIF format
# uses: actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1 # v4.6.1
# with:
# name: Differential ShellCheck SARIF
# path: ${{ steps.ShellCheck.outputs.sarif }}
# if: github.event_name == 'pull_request'

- name: Install Go
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0
Expand Down Expand Up @@ -161,17 +161,17 @@ jobs:
run: mkdir -p "${GOCOVERDIR}"
if: env.GOCOVERDIR != ''

- name: Run static analysis
env:
GITHUB_BEFORE: ${{ github.event.before }}
run: |
set -eux
sudo chmod o+w ./lxd/metadata/configuration.json
sudo chmod o+w ./doc/metadata.txt
sudo chmod o+w ./po/*
sudo chmod o+w ./lxd/auth/entitlements_generated.go
sudo chmod o+w ./lxd/auth/drivers/openfga_model.openfga
make static-analysis
# - name: Run static analysis
# env:
# GITHUB_BEFORE: ${{ github.event.before }}
# run: |
# set -eux
# sudo chmod o+w ./lxd/metadata/configuration.json
# sudo chmod o+w ./doc/metadata.txt
# sudo chmod o+w ./po/*
# sudo chmod o+w ./lxd/auth/entitlements_generated.go
# sudo chmod o+w ./lxd/auth/drivers/openfga_model.openfga
# make static-analysis

- name: Unit tests (all)
run: |
Expand Down
Loading

0 comments on commit 825fef8

Please sign in to comment.