Skip to content

Commit

Permalink
Bump Go min to 1.23 (stable-5.0) (#15069)
Browse files Browse the repository at this point in the history
Supersedes #15052
  • Loading branch information
tomponline authored Feb 25, 2025
2 parents eea0cc4 + 9ec28d6 commit d127915
Show file tree
Hide file tree
Showing 10 changed files with 80 additions and 94 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ jobs:
strip -s /tmp/bin/*
# bin/min/max (sizes are in MiB)
SIZES="lxc 15 16
lxd-agent 13 14"
SIZES="lxc 16 17
lxd-agent 14 15"
MIB="$((1024 * 1024))"
while read -r bin min max; do
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ TAG_SQLITE3=$(shell printf "$(HASH)include <dqlite.h>\nvoid main(){dqlite_node_i
GOPATH ?= $(shell go env GOPATH)
CGO_LDFLAGS_ALLOW ?= (-Wl,-wrap,pthread_create)|(-Wl,-z,now)
SPHINXENV=doc/.sphinx/venv/bin/activate
GOMIN=1.22.7
GOMIN=1.23.0
DQLITE_BRANCH=lts-1.17.x

ifneq "$(wildcard vendor)" ""
Expand Down
2 changes: 1 addition & 1 deletion doc/requirements.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
(requirements-go)=
## Go

LXD requires Go 1.22.7 or higher and is only tested with the Golang compiler.
LXD requires Go 1.23.0 or higher and is only tested with the Golang compiler.

We recommend having at least 2GB of RAM to allow the build to complete.

Expand Down
34 changes: 17 additions & 17 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/canonical/lxd

go 1.22.7
go 1.23.0

// https://github.com/minio/minio-go/issues/1931
replace github.com/minio/minio-go/v7 => github.com/minio/minio-go/v7 v7.0.66
Expand All @@ -11,7 +11,7 @@ require (
github.com/canonical/candid v1.12.3
github.com/canonical/go-dqlite/v2 v2.0.0
github.com/checkpoint-restore/go-criu/v6 v6.3.0
github.com/digitalocean/go-qemu v0.0.0-20230711162256-2e3d0186973e
github.com/digitalocean/go-qemu v0.0.0-20250212194115-ee9b0668d242
github.com/digitalocean/go-smbios v0.0.0-20180907143718-390a4f403a8e
github.com/dustinkirkland/golang-petname v0.0.0-20240428194347-eebcea082ee0
github.com/flosch/pongo2 v0.0.0-20200913210552-0d938eb266f3
Expand All @@ -35,7 +35,7 @@ require (
github.com/mdlayher/netx v0.0.0-20230430222610-7e21880baee8
github.com/mdlayher/vsock v1.2.1
github.com/miekg/dns v1.1.63
github.com/minio/minio-go/v7 v7.0.81
github.com/minio/minio-go/v7 v7.0.87
github.com/mitchellh/mapstructure v1.5.0
github.com/olekukonko/tablewriter v0.0.5
github.com/osrg/gobgp/v3 v3.34.0
Expand All @@ -47,8 +47,8 @@ require (
github.com/stretchr/testify v1.10.0
github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635
github.com/zitadel/oidc/v2 v2.12.2
golang.org/x/crypto v0.33.0
golang.org/x/oauth2 v0.26.0
golang.org/x/crypto v0.35.0
golang.org/x/oauth2 v0.27.0
golang.org/x/sync v0.11.0
golang.org/x/sys v0.30.0
golang.org/x/term v0.29.0
Expand All @@ -57,7 +57,7 @@ require (
gopkg.in/juju/environschema.v1 v1.0.1
gopkg.in/tomb.v2 v2.0.0-20161208151619-d5d1b5820637
gopkg.in/yaml.v2 v2.4.0
k8s.io/utils v0.0.0-20241104163129-6fe5fd82f078
k8s.io/utils v0.0.0-20241210054802-24370beab758
)

require (
Expand Down Expand Up @@ -89,8 +89,8 @@ require (
github.com/juju/webbrowser v1.0.0 // indirect
github.com/julienschmidt/httprouter v1.3.0 // indirect
github.com/k-sone/critbitgo v1.4.0 // indirect
github.com/klauspost/compress v1.17.11 // indirect
github.com/klauspost/cpuid/v2 v2.2.9 // indirect
github.com/klauspost/compress v1.18.0 // indirect
github.com/klauspost/cpuid/v2 v2.2.10 // indirect
github.com/kr/fs v0.1.0 // indirect
github.com/magiconair/properties v1.8.9 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
Expand All @@ -110,24 +110,24 @@ require (
github.com/rogpeppe/fastuuid v1.2.0 // indirect
github.com/rs/xid v1.6.0 // indirect
github.com/russross/blackfriday/v2 v2.1.0 // indirect
github.com/sagikazarmark/locafero v0.6.0 // indirect
github.com/sagikazarmark/locafero v0.7.0 // indirect
github.com/sagikazarmark/slog-shim v0.1.0 // indirect
github.com/sourcegraph/conc v0.3.0 // indirect
github.com/spf13/afero v1.11.0 // indirect
github.com/spf13/cast v1.7.0 // indirect
github.com/spf13/afero v1.12.0 // indirect
github.com/spf13/cast v1.7.1 // indirect
github.com/spf13/pflag v1.0.6 // indirect
github.com/spf13/viper v1.19.0 // indirect
github.com/subosito/gotenv v1.6.0 // indirect
github.com/vishvananda/netlink v1.3.0 // indirect
github.com/vishvananda/netns v0.0.5 // indirect
go.uber.org/atomic v1.11.0 // indirect
go.uber.org/multierr v1.11.0 // indirect
golang.org/x/exp v0.0.0-20241204233417-43b7b7cde48d // indirect
golang.org/x/mod v0.22.0 // indirect
golang.org/x/net v0.33.0 // indirect
golang.org/x/tools v0.28.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241206012308-a4fef0638583 // indirect
google.golang.org/grpc v1.68.1 // indirect
golang.org/x/exp v0.0.0-20250218142911-aa4b98e5adaa // indirect
golang.org/x/mod v0.23.0 // indirect
golang.org/x/net v0.35.0 // indirect
golang.org/x/tools v0.30.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250224174004-546df14abb99 // indirect
google.golang.org/grpc v1.70.0 // indirect
gopkg.in/errgo.v1 v1.0.1 // indirect
gopkg.in/go-jose/go-jose.v2 v2.6.3 // indirect
gopkg.in/httprequest.v1 v1.2.1 // indirect
Expand Down
Loading

0 comments on commit d127915

Please sign in to comment.