-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: Revert map[string]string
change for server settings
#13498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c9b39ed. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 0410572. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit f46b54b. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 9e9c362. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 2346992. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit c746027. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 517dc0f. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit d5c0ce6. Signed-off-by: Julian Pelizäus <[email protected]>
This reverts commit 43d1eb1. Signed-off-by: Julian Pelizäus <[email protected]>
tomponline
reviewed
May 23, 2024
This reverts commit 466f9cd. Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
tomponline
reviewed
May 24, 2024
tomponline
reviewed
May 24, 2024
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
@MusicDin using your reproducer I can confirm this unblocks the failing client when using a 5.0.3 server with the require github.com/canonical/lxd v0.0.0-20240523230039-b975d5778417
replace github.com/canonical/lxd => /home/julian/dev/lxd // changes from this PR
|
Yep. Thank you very much 🚀 |
tomponline
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the change of the server config from
map[string]any
tomap[string]string
performed in #13373 as it breaks thelxc
client when talking to older servers that still return amap[string]any
on the clientsGetServer()
call.See the reproducer steps here #13373 (comment).
It still keeps the bits from #13373 that removed the hidden configuration option as those changes are not connected with each other.
An option would have been to adapt the client to be able to talk with both the newer and older server but users of the pure REST API are also affected by this as config settings that were originally an
int
orbool
are now returned as astring
.Contrary when setting the value they always have to be provided as a
string
in the JSON payload.To not break the API we have to keep
map[string]any
.