Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to override key repeat rate and delay #3748

Conversation

tarek-y-ismail
Copy link
Contributor

@tarek-y-ismail tarek-y-ismail commented Feb 10, 2025

Closes #3737

Wasn't sure whether these changes fit in the cursor scaling PR or not. Nonetheless, they depend on some changes from it, specifically the following chunk which merges changes from the input config and the command line/env/etc:

https://github.com/canonical/mir/pull/3735/files#diff-cab2d87fa32f5bd035e2ffb1ebaf95cb5fdcf4ce79543ea2136af92fee83093eR131-R141

@tarek-y-ismail tarek-y-ismail self-assigned this Feb 10, 2025
@tarek-y-ismail tarek-y-ismail requested a review from a team as a code owner February 10, 2025 10:47
@tarek-y-ismail tarek-y-ismail linked an issue Feb 10, 2025 that may be closed by this pull request
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document how these interact with enable-key-repeat?

src/miral/input_device_config.cpp Outdated Show resolved Hide resolved
src/miral/input_device_config.cpp Outdated Show resolved Hide resolved
@tarek-y-ismail
Copy link
Contributor Author

Should we document how these interact with enable-key-repeat?

Don't see a reason for this. Pretty self explanatory. If you disable key repeat, then the delay or the rate doesn't matter.

@tarek-y-ismail tarek-y-ismail force-pushed the key-repeat-and-delay-missing-overrides branch from 2fc09da to 13cbeae Compare February 10, 2025 11:57
@tarek-y-ismail tarek-y-ismail merged commit 195e28d into MIRENG-899/cursor-scaling-support Feb 11, 2025
21 of 28 checks passed
@tarek-y-ismail tarek-y-ismail deleted the key-repeat-and-delay-missing-overrides branch February 11, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard repeat and delay missing override from command line
2 participants