Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaylandExecutor should implement time::AlarmFactory (and probably the rest of MainLoop?) #3739

Open
RAOF opened this issue Feb 6, 2025 · 0 comments

Comments

@RAOF
Copy link
Contributor

RAOF commented Feb 6, 2025

The Wayland event loop pretty much implements our MainLoop interfaces - timers, signal watches, fd watches. When interacting with Wayland it's almost always necessary to do so from the Wayland event loop, so currently when we want to watch a file descriptor and then do something on the Wayland loop, or set a timer to do something on the Wayland loop we need to first set the timer, and then from the callback push another callback into the WaylandExecutor that can then be run on the Wayland loop.

Instead we could just have a Wayland-main-loop-backed implementation of MainLoop that does everything on the event loop, making everything cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant