Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Process tests crash/fail on Windows #3787

Closed
Sploder12 opened this issue Nov 22, 2024 · 1 comment · Fixed by #3789
Closed

Basic Process tests crash/fail on Windows #3787

Sploder12 opened this issue Nov 22, 2024 · 1 comment · Fixed by #3789
Labels
bug jira Create a Jira ticket for this issue

Comments

@Sploder12
Copy link
Contributor

Sploder12 commented Nov 22, 2024 •
edited
Loading

Describe the bug
When running tests locally on Windows, basic process tests that test for crashing will fail. This is from a combination of issues, the first being trying to get the value of a std::nullopt, the second being a difference in how QProcess and Windows handles abort.

To Reproduce

  1. Run tests on Windows
  2. Observe the test suite crash or have basic process tests fail

Expected behavior
The tests pass and other tests continue

Additional info

  • OS: Windows 10 Home/Pro

Additional context
These tests seem to pass in CI but not locally for me. They fail on my dedicated Windows 10 Home machine and my Windows 10 Pro VM. Related to debug vs release building.
@Sploder12 Sploder12 added bug needs triage Issue needs to be triaged jira Create a Jira ticket for this issue labels Nov 22, 2024
@Sploder12 Sploder12 mentioned this issue Nov 22, 2024
Merged
@Sploder12 Sploder12 added needs triage Issue needs to be triaged good first issue and removed needs triage Issue needs to be triaged good first issue labels Nov 25, 2024
@Sploder12
Copy link
Contributor Author

All the label modification is for identifying a bug with the Jira sync tool.

@ricab ricab added jira Create a Jira ticket for this issue and removed needs triage Issue needs to be triaged jira Create a Jira ticket for this issue labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug jira Create a Jira ticket for this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix basic process tests on Windows canonical/multipass
2 participants
@ricab @Sploder12