Automatic gui version #3806
Automatic gui version #3806
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3806 +/- ##
==========================================
- Coverage 88.95% 88.94% -0.01%
==========================================
Files 256 256
Lines 14584 14584
==========================================
- Hits 12973 12972 -1
- Misses 1611 1612 +1 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
automatic-gui-version
branch
from
2527d75 to
5732634
Compare
andrei-toterman
added
jira
andrei-toterman
force-pushed
the
automatic-gui-version
branch
from
5732634 to
0925844
Compare
| else() | ||
| message(FATAL_ERROR "Invalid tag detected: ${NEW_VERSION}") | ||
| endif() | ||
|
|
There was a problem hiding this comment.
This whole block could be run as a separate step, right? Could we have a separate function for it instead, and call it only where relevant (i.e. Flutter build, possibly MSI stuff later)?
There was a problem hiding this comment.
I can't be sure what you are referring to, because GitHub shows you highlighted only an empty line, but I guess you mean this whole new algorithm for extracting those two version components. And yes, we could definitely move it to a new function and call it only in the GUI cmake file.
There was a problem hiding this comment.
Yes, that is what I meant. Should have been clearer. BTW, I like that you are printing the vars that are getting derived. It would be nice if you could keep that.
andrei-toterman
force-pushed
the
automatic-gui-version
branch
from
4a313e7 to
706cc87
Compare
Set the GUI version using the --build-name and --build-number args, using the MULTIPASS_VERSION CMake var. This way, we don't have to manually update the version all the time.
For the --build-number, the argument must only contain digits, so we extract the digits out of the commit hash respective to the current version.
MULTI-1702