-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SECURITY.md #3827
base: main
Are you sure you want to change the base?
Create SECURITY.md #3827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just some nitpicking from me.
Add a SECURITY.md file, documenting Multipass's security policy, along with instructions for reporting vulnerabilities and keeping up to date with supported releases.
Co-authored-by: trevor-shoe <[email protected]>
Co-authored-by: trevor-shoe <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3827 +/- ##
=======================================
Coverage 88.95% 88.95%
=======================================
Files 256 256
Lines 14584 14584
=======================================
Hits 12973 12973
Misses 1611 1611 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Hi @ricab , I've submitted my review. There are some suggestions based on our style guide, some suggested rewordings and small nitpicks. |
Co-authored-by: Giulia Zanchi <[email protected]>
Thanks for the review @giuliazanchi! I accepted most of your suggestions, so it's ready for another pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ricardo, it looks OK to me, plus that comment on "GitHub docs" vs "GitHub's docs" that I shared elsewhere. I'll leave that choice to you :)
@giuliazanchi and @Sploder12, are you good with this now? Any objections to merging this manually? |
Add a SECURITY.md file, documenting Multipass's security policy, along with instructions for reporting vulnerabilities and keeping up to date with supported releases.
MULTI-1419