Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SECURITY.md #3827

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Create SECURITY.md #3827

wants to merge 9 commits into from

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Dec 9, 2024

Add a SECURITY.md file, documenting Multipass's security policy, along with instructions for reporting vulnerabilities and keeping up to date with supported releases.

MULTI-1419

@ricab ricab requested a review from giuliazanchi December 9, 2024 19:37
@ricab ricab marked this pull request as ready for review December 9, 2024 19:44
Copy link
Contributor

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some nitpicking from me.

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
ricab and others added 6 commits December 10, 2024 17:50
Add a SECURITY.md file, documenting Multipass's security policy, along
with instructions for reporting vulnerabilities and keeping up to date
with supported releases.
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (9d4c63e) to head (31832a2).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3827   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         256      256           
  Lines       14584    14584           
=======================================
  Hits        12973    12973           
  Misses       1611     1611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jibel
jibel previously approved these changes Dec 11, 2024
Copy link
Collaborator

@jibel jibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Show resolved Hide resolved
@giuliazanchi
Copy link
Contributor

Hi @ricab , I've submitted my review. There are some suggestions based on our style guide, some suggested rewordings and small nitpicks.

Co-authored-by: Giulia Zanchi <[email protected]>
@ricab
Copy link
Collaborator Author

ricab commented Dec 11, 2024

Thanks for the review @giuliazanchi! I accepted most of your suggestions, so it's ready for another pass.

giuliazanchi
giuliazanchi previously approved these changes Dec 12, 2024
Copy link
Contributor

@giuliazanchi giuliazanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ricardo, it looks OK to me, plus that comment on "GitHub docs" vs "GitHub's docs" that I shared elsewhere. I'll leave that choice to you :)

@ricab
Copy link
Collaborator Author

ricab commented Dec 13, 2024

@giuliazanchi and @Sploder12, are you good with this now? Any objections to merging this manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants