Add `--force` argument to the `stop` command#1946

Merged

ricab merged 53 commits intomainfrom add-force-stop

Jul 4, 2024

+560-158

Commits on Jul 3, 2024

[rpc] Add option to force stopping an instance.

luis4a0
authored and
georgeliao
committed
[vm] Add bool to force shutdown.

luis4a0
authored and
georgeliao
committed
[cli] Handle command.

luis4a0
authored and
georgeliao
committed
[tests] Adapt stub and mock to new vm interface.

luis4a0
authored and
georgeliao
committed
[daemon] Handle forced stop command

luis4a0
authored and
georgeliao
committed
[tests] Use the new virtual_machine.h interface.

luis4a0
authored and
georgeliao
committed
[qemu] Implement forced stop.

luis4a0
authored and
georgeliao
committed
[lxd] Implement forced stop.

luis4a0
authored and
georgeliao
committed
[libvirt] Implement forced stop.

luis4a0
authored and
georgeliao
committed
refactor with main

sharder996
authored and
georgeliao
committed
[cli/stop] Make force a long option only

Chris Townsend
authored and
georgeliao
committed
[virtual_machine] Make force shutdown bool const

Chris Townsend
authored and
georgeliao
committed
[tests] Fix QEMU test for setting bool for shutdown()

Chris Townsend
authored and
georgeliao
committed
[tests/cli] Test the --force option for stop command

Chris Townsend
authored and
georgeliao
committed
[tests/qemu] Add tests for the force shutdown handling

Chris Townsend
authored and
georgeliao
committed
Update src/platform/backends/qemu/qemu_virtual_machine.cpp

authored and
georgeliao
committed
[tests] Fix tests due to change in log string

Chris Townsend
authored and
georgeliao
committed
[cli/stop] Be more specific with force stop help

Chris Townsend
authored and
georgeliao
committed
[utils/qemu_img] Add general function for deleting a snapshot image

Chris Townsend
authored and
georgeliao
committed
[backend/qemu] Delete suspend image on force shutdown

Chris Townsend
authored and
georgeliao
committed
[tests] Add qemu test for deleting suspend on force shutdown

Chris Townsend
authored and
georgeliao
committed
[qemu] Check if there is a suspend image in force shutdown

Chris Townsend
authored and
georgeliao
committed
[backend/qemu] Redo the shutdown logic

Chris Townsend
authored and
georgeliao
committed
[qemu] Redo some logic in how force shutdown is handled

Chris Townsend
authored and
georgeliao
committed
[vm] Don't enclose BaseVirtualMachine impl in multipass scope

Chris Townsend
authored and
georgeliao
committed
[exceptions] Add new exception types for VirtualMachine states

Chris Townsend
authored and
georgeliao
committed
[virtual_machine] Add method in base to check for states when stopping

Chris Townsend
authored and
georgeliao
committed
[backend/qemu] Add base VM state check handling for shutdown

Chris Townsend
authored and
georgeliao
committed
[tests] Fix/modify QEMU backend tests

Chris Townsend
authored and
georgeliao
committed
[qemu] Redo locking logic a bit to be more safe

Chris Townsend
authored and
georgeliao
committed
[libvirt] Redo shutdown logic based on new base method

Chris Townsend
authored and
georgeliao
committed
[tests] Fix/modify libvirt tests

Chris Townsend
authored and
georgeliao
committed
[tests] Add tests for libvirt shutdown

Chris Townsend
authored and
georgeliao
committed
[lxd] Add call to base class for checkoing shutdown states

Chris Townsend
authored and
georgeliao
committed
[tests] Adapt LXD backend tests for changes in shutdown

Chris Townsend
authored and
georgeliao
committed
[daemon] using lambda as opposed to std::bind to adapt functor.
georgeliao
committed
[qemu vm] use waiting for asynchronous process to finish as opposed to using condition variable wait where is no other thread notifies him. This fix the non-responding bug on qemu force stop.
georgeliao
committed
[qemu vm] move the lock into the check_state_for_shutdown function since the state variable is the only one needs to be protected, also convert unique_lock to scoped_lock because manual unlock/ loc…
georgeliao
committed
[daemon] small renaming for better clarity.
georgeliao
committed
[qemu] remove the state check and added the missing lock on state variable during the previous refactor commit.
georgeliao
committed
[virtual machine] reverted back the commit "move the lock into the check_state_for_shutdown function since the state variable is the only one needs to be protected, also convert unique_lock to scop…
georgeliao
committed
[qemu vm] removed unnecessary condition variable notification since we use vm_process->wait_for_finished to sync
georgeliao
committed
[lxd vm] small polishing of LXDVirtualMachine::shutdown code.
georgeliao
committed
[qemu vm] added if empty check to pass unit tests and check the return boolean of wait_for_finished and log correspondingly.
georgeliao
committed
[cmd] update the stop command description.
georgeliao
committed
[cmd] refined the force option help text based on the advice of the technical author.
georgeliao
committed
[lxd] address the review comment, change the function parameter to const reference.
georgeliao
committed
[qemu] refine the timeout values of wait_for_finished calls.
georgeliao
committed
[qemu] change log to throw exception in the case of killing process could not finish.
georgeliao
committed
[virtual machine] change the const bool to bool.
georgeliao
committed
Update src/platform/backends/libvirt/libvirt_virtual_machine.cpp

georgeliao
and
ricab
committed
[qemu] refined the qemu process killing can not finish error message.
georgeliao
committed
[daemon] changed adapter from std::bind to lambda.
georgeliao
committed