[snapshots] truncate snapshot comment on newline in overview #3176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## snapshots #3176 +/- ##
==========================================
Coverage 84.62% 84.62%
==========================================
Files 247 247
Lines 13106 13108 +2
==========================================
+ Hits 11091 11093 +2
Misses 2015 2015
|
ricab
force-pushed
the
truncate-snapshot-comment
branch
from
f0c206e to
67d6d39
Compare
ricab
force-pushed
the
truncate-snapshot-comment
branch
from
67d6d39 to
418bd9b
Compare
ricab
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Hey @sharder996, this looks good to me, thanks! Only a small suggestion inline.
I have rebased on the updated snapshots branch with the fix for the overviews and I am deferring testing for the next iteration.
ricab
approved these changes
Sep 7, 2023
ricab
added a commit
that referenced
this pull request
Oct 25, 2023
[snapshots] truncate snapshot comment on newline in overview r=ricab a=sharder996
ricab
added a commit
that referenced
this pull request
Oct 30, 2023
[snapshots] truncate snapshot comment on newline in overview r=ricab a=sharder996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.